Add aria-hidden to accordian content div#1519
Merged
nickbristow merged 1 commit intomasterfrom Jun 30, 2017
Merged
Conversation
**Why**: This tells the screen reader the content in this div is hidden. When the accordian is expanded, aria- hidden is changed to false, letting the screen reader know there is new content on screen.
nickbristow
force-pushed
the
add_aria_hidden_to_password_info
branch
from
d8a0e93 to
2c636fb
Compare
el-mapache
approved these changes
Jun 30, 2017
Contributor
el-mapache
left a comment
el-mapache
left a comment
There was a problem hiding this comment.
Accessibility question: do screen readers not consistently respect display: none, or is it just best practice to always include the aria-hidden attribute on nodes whose content can be displayed dynamically?
Looks good to me!
Contributor
Author
|
@el-mapache they do respect it, changing the aria hidden is a way to let the screen reader know things come and go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
This tells the screen reader the content in this div
is hidden. When the accordian is expanded, aria-
hidden is changed to false, letting the screen
reader know there is new content on screen.