Conversation
config/locales/zxcvbn/fr.yml
Outdated
There was a problem hiding this comment.
Yes, it is. It looks like it didn't get properly populated. @zachmargolis Is this the parsing issue you were mentioning?
There was a problem hiding this comment.
Yes, I'll have to take a look at this, oops
There was a problem hiding this comment.
Ok I pushed up the translations and fixed up the commit
There was a problem hiding this comment.
show password checkbox not translated
Looks like may be an issue with my setup according to @monfresh
|
@nickbristow On which screen are you not seeing the "Show password" checkbox in French? I see that the
|
|
@monfresh it might just be the manage or change password page.
|
|
@monfresh im not sure whats happening |
zachmargolis
force-pushed
the
margolis-add-translations
branch
from
8064fee to
d0ed55d
Compare
**Why**: Results back from vendor
|
I think it's easier to test this by running the app locally and looking at all the screens. Reading through the code is not a good way to review this PR, but it looks OK at first glance. I vote to merge this in, then test it thoroughly on |
|
I'm seeing the same bug as @nickbristow now. Let's open an issue for it. |
3 participants
Why: Results back from vendor