Skip to content

Check href when testing links#1512

Merged
monfresh merged 1 commit intomasterfrom
mb-update-view-spec
Jun 28, 2017
Merged

Check href when testing links#1512
monfresh merged 1 commit intomasterfrom
mb-update-view-spec

Conversation

@monfresh
Copy link
Contributor

Why: Testing for the link text alone is not enough. We also
want to make sure the link is pointing to the right place.

**Why**: Testing for the link text alone is not enough. We also
want to make sure the link is pointing to the right place.
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@monfresh monfresh merged commit ca03da1 into master Jun 28, 2017
@monfresh monfresh deleted the mb-update-view-spec branch June 28, 2017 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants