Deploy RC 439 to Production#11657
Merged
zachmargolis merged 19 commits intostages/prodfrom Dec 17, 2024
Merged
Conversation
* Use leading dot operators **Why** * Leading dots are the de facto style for chained methods in many programming languages, including the ones Ruby drew inspiration from * Leading dots make it clear that the next line is part of the previous code call. * RuboCop's default is leading dot style and has been since the cop was added in 2017. * Leading dot-operators have been supported in Ruby since 1.9 * IRB has supported pasting multiline code with leading dot operators since 2021 [skip changelog]
* changelog: Internal, Analytics, Add integration error event
changelog: Internal, Maintenance, Update actionpack to address security vulnerability
…s into URLs (#11620) * LG-15237 Allow the SP return URL resolver to interpolate locale values into URLs In #11591 we added a `post_idv_follow_up` URL in response to issues we were having getting users for a particular partner to return to their SP. This partner expressed concerns about have the appropriate locale for these users since they are returning to the partner without initiating a session at the partner. The original implementation for the change in #11591 included a locale param on the `post_idv_follow_up` URL. After some discussion with other engineers we identified that this pattern of hardcoding a param onto a single service providers was undesirable. This commit introduces the ability to include templateable values in these URLs and introduces the locale as one of those values. changelog: Internal, SP Configuration, Add the ability to specify a locale in a redirect URL
* Fix documentation for idv_doc_auth_submitted_image_upload_vendor * Fix formatting errors in other events too - Regex used /# [^@ ]/ changelog: Internal, Documentation, Fix documentation formatting
* rename to primary * placeholder * allow decoding id_token_hint with either OIDC key * remove extraneous class creation * support two keys changelog: Internal, OpenID Connect, Support two OIDC key-pairs --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* Remove allowed_extra_analytics changelog: Internal, Analytics, Document analytics events * Document analytics attributes * document analytic attr * Remove allowed_extra_analytics for recaptcha * update param documentation * document analytic attri for reCAPTCHA * restore original recaptcha args * delete allowed_extra_analytics in recaptcha spec * use allowed_extra_analytics to test extra props --------- Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
changelog: Internal, Analytics, Remove support for wildcard allowed_extra_analytics
changelog: Internal, Maintenance, Update simpleidn and faker gems
* Simplify OIDC Logout validation changelog: Internal, OpenID Connect, Simplify OIDC Logout validation * Update spec/forms/openid_connect_logout_form_spec.rb Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> --------- Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
changelog: Internal, Analytics, Remove support for allowed_extra_analytics
* Internal, Maintenance, Update to Ruby 3.3.6 and Node 22 changelog: Internal, Maintenance, Update to Ruby 3.3.6 and Node 22 * Update more Node 20 references * Explicitly define project as CommonJS Otherwise Mocha will attempt (and fail) to parse as ESM * Refactor device specs to use useDefineProperty helper Node.js now defines global.navigator * Force override global navigator with JSDOM navigator * Sync yarn.lock * update gems * update more gems * update image * add current path checks * update letter_opener --------- Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
… is not marked complete (#11625) We received feedback from a partner that users may think that they are done with the identity verification workflow on the personal key page because all of the steps on the step indicator are marked complete. This commit modifies the step indicator on the personal key page so the "Re-enter password" step is not complete on that page. Since there is not longer a case where all step indicator steps are complete this change also removes the `complete` status from the `StepIndicatorComponent`. [skip changelog]
[skip changelog]
* LG-15280 Update the alert for successful document capture When a user successfully complete document capture we showed an alert on the next screen that says "We successfully verified your ID". We received feedback that this may lead people to believe that they are finished with IdV. This commit updates the language to prevent any confusion. [skip changelog] * cleanup french apostrophe
* changelog: User-Facing Improvements, Authentication with SP, change link from add email to change email * make url options default * fix unnecessary spacing * update url options * change so all flows go to select email page * update completions presenter spec * update show link for a checking enabled and disabled functionality
…set Instructions (#11645) * Add translations for IPP PW reset * changelog: User-Facing Improvements, In-Person proofing, Add translations for IPP Password Reset Email * fix linter error * Remove key from allowed_untranslated list
aduth
approved these changes
Dec 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Internal