Remove support for wildcard allowed_extra_analytics#11643
Merged
Conversation
changelog: Internal, Analytics, Remove support for wildcard allowed_extra_analytics
Contributor
Author
|
Arguably we might be able to get rid of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates the behavior of
FakeAnalyticsextra analytics checker to only support individually allowlisted properties and not blanket wildcard exceptions.As of #11634, we have complete documentation coverage for every analytics event, thus removing the need for this override, which was introduced as a temporary solution when introducing the check, due to the level of effort in documenting existing analytics events.
📜 Testing Plan
Verify build passes.