Remove all supports for allowed extra analytics#11647
Merged
Conversation
changelog: Internal, Analytics, Remove support for allowed_extra_analytics
mitchellhenke
approved these changes
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Removes all support for
allowed_extra_analytics.Follows #11643, addressing the one remaining use-case of reCAPTCHA forms, which passthrough extra analytics, currently used to support optional
phone_country_codelogging. Testing with this property allows coverage for the behavior while avoiding flagging the extra analytics check.This is also meant to support #11605, which currently has some flakey test failures within the extra analytics checking global RSpec configuration.
📜 Testing Plan
Verify build passes.