LG-15237 Allow the SP return URL resolver to interpolate locale values into URLs#11620
Merged
LG-15237 Allow the SP return URL resolver to interpolate locale values into URLs#11620
Conversation
Contributor
Author
|
There are a few things in this pull request I'm not super confident about. I'll comment on them. |
jmhooper
commented
Dec 11, 2024
jmhooper
commented
Dec 11, 2024
…s into URLs In #11591 we added a `post_idv_follow_up` URL in response to issues we were having getting users for a particular partner to return to their SP. This partner expressed concerns about have the appropriate locale for these users since they are returning to the partner without initiating a session at the partner. The original implementation for the change in #11591 included a locale param on the `post_idv_follow_up` URL. After some discussion with other engineers we identified that this pattern of hardcoding a param onto a single service providers was undesirable. This commit introduces the ability to include templateable values in these URLs and introduces the locale as one of those values. changelog: Internal, SP Configuration, Add the ability to specify a locale in a redirect URL
jmhooper
force-pushed
the
jmhooper-add-locale-to-follow-up-url
branch
from
818434a to
652f76e
Compare
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
zachmargolis
approved these changes
Dec 11, 2024
Sgtpluck
approved these changes
Dec 12, 2024
Contributor
Author
|
Here is a pull request that prevents partners from modifying their configured We need that MR merged before we merge this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #11591 we added a
post_idv_follow_upURL in response to issues we were having getting users for a particular partner to return to their SP. This partner expressed concerns about have the appropriate locale for these users since they are returning to the partner without initiating a session at the partner.The original implementation for the change in #11591 included a locale param on the
post_idv_follow_upURL. After some discussion with other engineers we identified that this pattern of hardcoding a param onto a single service providers was undesirable. This commit introduces the ability to include template-able values in these URLs and introduces the locale as one of those values.