LG-15148 Add Translation to Pending In Person Warning for Password Reset Instructions#11645
Merged
gina-yamada merged 7 commits intomainfrom Dec 17, 2024
Merged
Conversation
WilliamBirdsall
approved these changes
Dec 16, 2024
Contributor
WilliamBirdsall
left a comment
There was a problem hiding this comment.
LGTM. Wonderful testing instructions! :)
shanechesnutt-ft
approved these changes
Dec 16, 2024
kellular
approved these changes
Dec 16, 2024
kellular
left a comment
There was a problem hiding this comment.
Cross-checked with the translations spreadsheet; LGTM
eileen-nava
approved these changes
Dec 16, 2024
Contributor
eileen-nava
left a comment
There was a problem hiding this comment.
This looks good. Thank you for linking the translations tracker from the PR description! It made the review process much smoother.
…48-add-translation-for-pw-reset
…48-add-translation-for-pw-reset
…48-add-translation-for-pw-reset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-15148 Update languages for alert to password reset email to notify user of progress loss
🛠 Summary of changes
📜 Testing Plan
http://localhost:3000/rails/mailers/user_mailer/reset_password_instructions_with_pending_in_person_warning.htmlfor Spanish, French, and Chinese to ensure content is updated correctly.📝 Translation Document
Refer to the sprint 327 tab, row 3 (item 1)
👀 Screenshots