Skip to content

LG-15148 Add Translation to Pending In Person Warning for Password Reset Instructions#11645

Merged
gina-yamada merged 7 commits intomainfrom
yamada/LG-15148-add-translation-for-pw-reset
Dec 17, 2024
Merged

LG-15148 Add Translation to Pending In Person Warning for Password Reset Instructions#11645
gina-yamada merged 7 commits intomainfrom
yamada/LG-15148-add-translation-for-pw-reset

Conversation

@gina-yamada
Copy link
Copy Markdown
Contributor

@gina-yamada gina-yamada commented Dec 16, 2024

🎫 Ticket

LG-15148 Update languages for alert to password reset email to notify user of progress loss

🛠 Summary of changes

  • Add Spanish, French, and Chinese translation for the warning banner in the password reset email for IPP (when profile has pending IPP enrollment)

📜 Testing Plan

  • Step 1: Inspect the email for content ensuring the translation have been updated properly. Start the server. Inspect the content inside the warning banner via http://localhost:3000/rails/mailers/user_mailer/reset_password_instructions_with_pending_in_person_warning.html for Spanish, French, and Chinese to ensure content is updated correctly.
  • Step 2: Take if for a test drive. Create an enrollment by moving through the IPP flow (coming in from Sinatra) in one of the languages (pick your language on http://localhost:3000/sign_up/enter_email when you create an account). Sign out. Go back to the login view (http://localhost:3000/), click the Forgot your password link. Fill out your email and continue. Inspect email.

📝 Translation Document

Refer to the sprint 327 tab, row 3 (item 1)

👀 Screenshots

before after
Screenshot 2024-12-16 at 8 26 48 AM Screenshot 2024-12-16 at 8 28 37 AM
Screenshot 2024-12-16 at 8 27 18 AM Screenshot 2024-12-16 at 8 29 14 AM
Screenshot 2024-12-16 at 8 27 44 AM Screenshot 2024-12-16 at 8 29 41 AM

Copy link
Copy Markdown
Contributor

@WilliamBirdsall WilliamBirdsall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Wonderful testing instructions! :)

Copy link
Copy Markdown
Contributor

@shanechesnutt-ft shanechesnutt-ft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that the translations match up. I didn't run it locally but things look good from my end! 👍🏻

Copy link
Copy Markdown

@kellular kellular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross-checked with the translations spreadsheet; LGTM

@gina-yamada gina-yamada removed the request for review from rutvigupta-design December 16, 2024 20:48
@eileen-nava eileen-nava self-requested a review December 16, 2024 21:28
Copy link
Copy Markdown
Contributor

@eileen-nava eileen-nava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thank you for linking the translations tracker from the PR description! It made the review process much smoother.

@gina-yamada gina-yamada merged commit 31db4c5 into main Dec 17, 2024
@gina-yamada gina-yamada deleted the yamada/LG-15148-add-translation-for-pw-reset branch December 17, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants