Document all of the remaining analytic events (IPP)#11634
Merged
gina-yamada merged 11 commits intomainfrom Dec 13, 2024
Merged
Conversation
changelog: Internal, Analytics, Document analytics events
gina-yamada
changed the title
aduth
reviewed
Dec 12, 2024
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Couple small changes to make, likely from my original commits.
But looks good otherwise!
Contributor
Author
|
Thanks, I should have read that test more carefully! Way more commits that needed. 🤦♀️ I will update with main and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Hackathon: Finish documenting all of the remaining analytic events (IPP)
🛠 Summary of changes
📜 Testing Plan
allowed_extra_analyticsin the code. Ensure remaining instances are used to test functionality around extra props