Merged
Conversation
changelog: Internal, OpenID Connect, Simplify OIDC Logout validation
aduth
approved these changes
Dec 16, 2024
Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
zachmargolis
approved these changes
Dec 16, 2024
mitchellhenke
deleted the
mitchellhenke/simplify-oidc-logout-verification
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
In working on 18F/omniauth_login_dot_gov#37, I noticed
JWT::decodeaccepts an array of certs for verification. Since we don't keep track of which cert is used here, we can avoid iterating and just pass the array.