Merged
Conversation
…p 4.5 of 6 (#11455) * feat: remove all instances of skip_doc_auth and skipDocAuth * changelog: Internal, In-person proofing, remove old skip_doc_auth variable * feat: remove skip_doc_auth from document capture controller * feat: lintfix
…ing phone (#11521) changelog: Bug Fixes, Authentication Apps, Fix error code for invalid format mentioning code sent to phone
* lg-15077 update sensitivetag changelog: Internal, Reporting,remove system tbale and updatesentitive missed tags * migration comment append
[skip changelog] Remove allow extra analytics * from dev_rake_spec.rb to fix "Unnecessary allowed_extra_analytics" error.
LG-14007: wait for Socure result If the user returns from Socure before the job has finished fetching the results, wait and check every 15 seconds. [skip changelog] * new socure wait page * make wait polling interval configurable * set a timeout for waiting for Socure data Note: removes `cancel_establishing_in_person_enrollments` from DocumentCaptureController Spoke with Team Joy and the issue this was addressing is OBE
[skip changelog]
* Change socure_enabled config to socure_docv_enabled Reduce potential confusion between doc auth and identity resolution Socure implementations [skip changelog] * socure_document_request_endpoint -> socure_docv_document_request_endpoint Maybe a little redundant, but it's (somewhat) consistent? * Remove socure_standard_capture_desktop_enabled Does not appear to be referenced anywhere * Remove socure_webhook_enabled does not appear to be referenced * socure_webhook_secret_key_queue -> socure_docv_webhook_secret_key_queue * socure_webhook_secret_key -> socure_docv_webhook_secret_key * let's get it sorted in here * normalize_yaml yaml is good
It looks like in 1767dd5 we introduced a typo where `request_ip` was spelled `request_id`. This resulted in us sending a null `request_ip` to Threatmetrix. This commit fixes the typo and modifies a spec to make sure the expected arguments are sent to the proofer. [skip changelog]
changelog: Internal, In-person proofing, Remove deprecated state ID step routes `verify/in_person_proofing/state_id`
…ls (#11520) changelog: In-person proofing, User-Facing Improvements, Add PO search link to barcode page and ready to verify emails
* changelog: Internal, Analytics, Exclude stale sessions in IAL2 usage query
…ment PII (#11499) * LG-13761: ProofingComponents to store real vendor used to verify document PII **Why** * Prior to this change, we always stored 'aamva' in a `User`'s `proofing_components.source_check` column regardless of whether a call to AAMVA was made or not. Accuracy is good and storing the actual "vendor_name" will align our analytics across our events. **How** * Instead of hard-coding `vendor_name` in `proofing_components.source_check`, we dig into the result object (as produced by the `ResultAdjudicator`) for the actual vendor_name. This value should always be present even though we don't have any validators for it. * Adds `:source_check_vendor` field to `Idv::Session` to capture the vendor name actually utilized to validate the state ID attributes. * Pulling `vendor_name` from the result object makes testing a little messier, cleaning up the various vendor names in our specs should be done in future work. For now, a new constant with the known `source_check` names has been added (`Idv::Constants::Vendors::SOURCE_CHECK`). * No new specs have been added as the functionality hasn't changed, but the relevant specs, including one end-to-end feature test, have been updated to check the vendor name is in the expected list or matches a placeholder value. changelog: Internal, Analytics, Store correct vendor name in ProofingComponents
aduth
requested review from
KeithNava,
Sgtpluck,
jennyverdeyen,
jmhooper,
lmgeorge,
matthinz,
samathad2023 and
shanechesnutt-ft
mitchellhenke
approved these changes
Nov 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fixes
Internal