Conversation
KeithNava
force-pushed
the
keithw/LG-13006-rename-skip-doc-auth-value-step-4-removal
branch
from
f371201 to
b56eadc
Compare
Contributor
shanechesnutt-ft
left a comment
shanechesnutt-ft
left a comment
There was a problem hiding this comment.
Looks go so far. I noticed that the app/services/idv/session.rb and app/controllers/idv/socure/document_capture_controller.rb still have skip_doc_auth items have you looked at those? I wasn't sure if you meant to leave those in or not.
KeithNava
force-pushed
the
keithw/LG-13006-rename-skip-doc-auth-value-step-4-removal
branch
from
b56eadc to
336a20c
Compare
Contributor
jennyverdeyen
left a comment
jennyverdeyen
left a comment
There was a problem hiding this comment.
This is looking good to me - I just see one remaining instance of skip_doc_auth in app/services/idv/session.rb still, unless that is intentional!
Contributor
Author
|
@shanechesnutt-ft @jennyverdeyen thanks for the callouts, we actually have the removal of the variable from the session.rb as the next after the deployment in the ticket 👉 https://cm-jira.usa.gov/browse/LG-13006 |
shanechesnutt-ft
approved these changes
Nov 14, 2024
Contributor
shanechesnutt-ft
left a comment
shanechesnutt-ft
left a comment
There was a problem hiding this comment.
Looks good to me! 👍🏻
KeithNava
deleted the
keithw/LG-13006-rename-skip-doc-auth-value-step-4-removal
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-13006
🛠 Summary of changes
This is one of the last steps a part of the parent ticket LG-13006 to remove the old
skip_doc_authvariable after the newrenamed variable of
skip_doc_auth_from_how_to_verifywas introduced