Merged
Conversation
It looks like in 1767dd5 we introduced a typo where `request_ip` was spelled `request_id`. This resulted in us send a null `request_ip` to Threatmetrix. This commit fixes the typo and modifies a spec to make sure the expected arguments are sent to the proofer. [skip changelog]
mitchellhenke
approved these changes
Nov 19, 2024
matthinz
approved these changes
Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like in 1767dd5 we introduced a typo where
request_ipwas spelledrequest_id. This resulted in us sending a nullrequest_ipto Threatmetrix.This commit fixes the typo and modifies a spec to make sure the expected arguments are sent to the proofer.