LG-14814: Entering TOTP code in wrong format shows error text mentioning phone#11521
Merged
LG-14814: Entering TOTP code in wrong format shows error text mentioning phone#11521
Conversation
…ing phone changelog: Bug Fixes, Authentication Apps, Fix error code for invalid format mentioning code sent to phone
zachmargolis
approved these changes
Nov 18, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-14814
🛠 Summary of changes
Fixes an issue where entering TOTP (Authentication App) code in the wrong format shows an error message mentioning a code "sent to your phone".
This is related to LG-13450 (#10898), where we changed the error message, intending it to apply for phone-sent codes (OTP via SMS or Voice), but shared code between phone OTP and TOTP caused the error to be used in both places.
The solution here is to restore the shared code instance to use generic language, and override to use the phone-specific languages in those use-cases.
📜 Testing Plan
Verify TOTP invalid format shows generic message:
Verify no regressions in phone OTP invalid format showing specialized message:
👀 Screenshots