LG-15090: Update Socure config key names#11512
Merged
Conversation
Reduce potential confusion between doc auth and identity resolution Socure implementations [skip changelog]
…oint Maybe a little redundant, but it's (somewhat) consistent?
Does not appear to be referenced anywhere
does not appear to be referenced
matthinz
requested review from
a team and
amirbey
and removed request for
a team
yaml is good
n1zyy
approved these changes
Nov 15, 2024
Contributor
n1zyy
left a comment
n1zyy
left a comment
There was a problem hiding this comment.
I'm Matt Wagner and I approve this message commit.
I'd hold off merging until someone from Team Timnit confirms they're good with the dropped keys, though.
Do we need to worry about any of these keys already being set in S3 and having to be renamed at deploy-time? I'm assuming not because the feature isn't live yet, but I want to confirm nothing nasty will happen when this is deployed.
lmgeorge
approved these changes
Nov 18, 2024
Contributor
lmgeorge
left a comment
lmgeorge
left a comment
There was a problem hiding this comment.
LGTM, similar Matt W's concerns, want to make sure @18F/identity-timnit signs off and there won't be any need to do the Deploy Shuffle with these config changes.
amirbey
approved these changes
Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-15090
-->
🛠 Summary of changes
We identified while testing #11479 that some Socure-related config keys, though their names imply they apply globally, actually only apply to the doc auth integration. This PR:
socure_*tosocure_docv_*