LG-12269 Improve ID-IPP feature test structure

[shanechesnutt-ft]

🎫 Ticket

Link to the relevant ticket:
LG-12269

🛠 Summary of changes

Improved test structure in the feature tests for the ID-IPP flow.

📜 Testing Plan

• Tests are passing in CI

[eileen-nava]

Approved. I left non-blocking comments.

[eileen-nava]

Nit: While making changes in here, what would you think of changing before(:each) to before? Since before's scope defaults to each, I'm not sure the benefit of writing before(:each) instead of before.

I'm also wondering if it's be worth changing the capitalization for validation, too?

[shanechesnutt-ft]

Nice catch I will update those

[eileen-nava]

spec/support/features/in_person_helper.rb includes the complete_all_in_person_proofing_steps method and spec/support/features/doc_auth_helper.rb includes the complete_up_to_how_to_verify_step_for_opt_in_ipp method, both of which are somewhat similar to this method. What would you think of moving this method to the in_person_helper?

[shanechesnutt-ft]

I can do that. That will be a good way to dry things up.

[gina-yamada]

My initial review is complete. Please reach out if/when you'd like another review. Comments are non-blocking and I approve so far. I will wait for final stamp though as I think you are looking into some of the above comments.

[gina-yamada]

@shanechesnutt-ft Why was app/controllers/idv/in_person/ready_to_verify_controller.rb deleted?

[shanechesnutt-ft]

@shanechesnutt-ft Why was app/controllers/idv/in_person/ready_to_verify_controller.rb deleted?

That was a mistake on my part

[eileen-nava]

I took another look at your changes and they look good. Approved again!

[eileen-nava]

🙌🏻