Merged
Conversation
Previous commits added the `Pii::StateId` data class. This is intended to hold the data that is read from the state ID. This has several advantages over the old approach (holding this data in a Hash): 1. It is immutable so it will error if you try to add data not from the state ID 2. It has defined attributes that are all required so you know what data will be present This commit takes the next step in integrating this tool which is modifying `idv_session#pii_from_doc` to serialize the PII before it is written to the session and then deserialize it into `Pii::StateId` on read. [skip changelog]
) * Don't tell users to get another letter when they can't changelog: User-Facing Improvements, Identity verification, Don't tell users to request a new verify by mail letter when they can't. * Initial crack at ZH translation * Update expected error in feature test * Update another feature test expected error
It's managed by a secret in the helm chart now changelog: Internal, reviewapps, remove postgres creds to make latest version of helm chart happy
changelog: Internal, Component Previews, Support localization for component previews
* add faraday servererror to network errors * move error to appropriate job * update refresh job spec to include server error * Use FakeAnalytics instead of stubbing to get clearer specs * log job completed * changelog: Internal, UspsAuthTokenRefreshJob, rescue Faraday::ServerError --------- Co-authored-by: Zach Margolis <zachary.margolis@gsa.gov>
changelog: Internal, Code Quality, Remove unused code
* Change inline error * changelog: User-Facing Improvements, Selfie, Fix inline error text above selfie box * Remove unusual line terminators (auto detected by VS Code) * Change translations too * Lint fix * Add chinese translation * Remove newly translated key from exception list * Add tests for inline selfie errors * Lint fixes * Fix space (remove b/c odd whitespace character)
* resolve conflict encountered during main rebase * consolidate selfie not_live and poor_quality i18n * update spec key for liveness error message * [skip changelog] * happy linting * remove dup tests and add scenarios * key no longer exists
* Refactor reCAPTCHA validator as form model changelog: Internal, reCAPTCHA, Refactor reCAPTCHA validator as form model * Update spec stubs * Update mock validator specs
* initial translations changelog: Internal, Translations, Update existing translations for French and Spanish Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
changelog: Internal, Dependencies, Update dependencies to latest versions
changelog: Internal, Database, Drop unused column
changelog: Internal, reCAPTCHA, Configure reCAPTCHA score threshold for local development
* Move, rename reCAPTCHA validator as form changelog: Internal, reCAPTCHA, Refactor reCAPTCHA validator as form model * Update more validator references * Disambiguate form variable name
changelog: Internal, Code Quality, Fix typos in code naming
changelog: Internal, Code Quality, Remove unused method
* changelog: Internal, Logging, Adding dn uuid to logging dn configuration for easier cross pki logging * include user uuid to query * use key id * update rspec so it accounts for key id * update rspec and fix tests * fix spec * make sure to still send foo * move setting up key id to when we decode token * replace self
This commit makes changes to the Enter Code screen in the welcome back flow. It updates the address and “Clear my information and start over” link to be in an accordion, makes content updates, and rearranges some of the elements. [skip changelog]
#10558) changelog: User-Facing Inprovements, IdV, Update spanish LQA translation on agreement step
This commit makes changes to the "Didn't get your letter" screen in the welcome back flow. It updates the address and “Clear my information and start over” link to be in an accordion, makes content updates, and rearranges some of the elements. [skip changelog]
aduth
approved these changes
May 7, 2024
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Can we add the changelog to the pull request comment?
Contributor
Author
|
Closing because I am not sure if I pulled down from main correctly. |
Contributor
It looked fine to me? We don't deploy from |
Contributor
Author
|
Ah...that does look correct. Now the problem I am running into is that I cannot generate another changelog. To solve, I should delete the branch and re-run the script, but after it is deleted, it says the branch still exists. |
Contributor
Author
|
Reopening after re-obtaining changelog notes |
Contributor
|
@solipet Staging deploys daily around noon, I think it's expected if it was merged yesterday afternoon it wouldn't be included here. Does it need to be included or can it wait until Thursday? |
* LG-12553: A/B Test for 10-digit IdV OTP This PR sets up an A/B test where one group gets the current six alphanumeric character OTP, and the other group gets the new ten numeric digit OTP under test. The test bucket they are put in is logged in most IdV events. changelog: User-Facing Improvements, Identity Verification, A/B test to try out 10-digit voice OTP for Identity Verification
jmdembe
dismissed
solipet’s stale review
Commit for #10480 were cherry-picked into the branch, changelog note added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Internal