LG-12946: piv cac logging improvements #10512
Merged
Conversation
…ion for easier cross pki logging
aduth
reviewed
Apr 26, 2024
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
What about users who sign-in using passwordless "Sign in with your government employee ID" ? We don't know which user they are until we get the result from PKI, so we can't send that information.
Contributor
|
From the ticket, I thought the idea would be to include |
aduth
reviewed
May 2, 2024
aduth
approved these changes
May 3, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://cm-jira.usa.gov/browse/LG-12946
🛠 Summary of changes
Add additional logging so that we can better tie pki nad idp logging together.