LG-11753 Update Enter Code (formerly, Welcome Back) Screen#10344
Merged
LG-11753 Update Enter Code (formerly, Welcome Back) Screen#10344
Conversation
Contributor
Author
|
Here are screenshots of the updated enter-code screen: English: English with alerts: Spanish: Spanish with alerts: French: French with alerts: |
Contributor
Author
|
It looks like moving the "Clear my information and start over" link into the accordion has caused some issues with feature specs. I am going to go through and tackle those. |
jmhooper
force-pushed
the
jmhooper-redo-enter-gpo-code-screen
branch
2 times, most recently
from
094d9ef to
e856b34
Compare
Contributor
Author
|
The Accordion Body in the screenshots is actually not correct. Where is says "Where was my letter sent?" it should say "We sent a letter with your verification code to:". I have fixed that issue. |
theabrad
approved these changes
Apr 2, 2024
Contributor
theabrad
left a comment
theabrad
left a comment
There was a problem hiding this comment.
Ran it locally. Screenshots matched. LGTM
theabrad
requested changes
Apr 2, 2024
Contributor
theabrad
left a comment
theabrad
left a comment
There was a problem hiding this comment.
Looking at the AC: The "Confirm account" button should be changed to "Submit"
Contributor
Author
theabrad
approved these changes
Apr 3, 2024
This commit makes changes to the Enter Code screen in the welcome back flow. It updates the address and “Clear my information and start over” link to be in an accordion, makes content updates, and rearranges some of the elements. [skip changelog]
jmhooper
force-pushed
the
jmhooper-redo-enter-gpo-code-screen
branch
from
ab623ce to
1856943
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes changes to the Enter Code screen in the welcome back flow. It updates the address and “Clear my information and start over” link to be in an accordion, makes content updates, and rearranges some of the elements.