LG-13009 - consolidate poor quality and not live messaging#10536
LG-13009 - consolidate poor quality and not live messaging#10536
Conversation
amirbey
force-pushed
the
amirbey/LG-13009-expected-face-error-msg
branch
from
a8c53f4 to
b3bee0a
Compare
There was a problem hiding this comment.
TIL blank includes nil!
There was a problem hiding this comment.
this method name was very confusing
night-jellyfish
left a comment
night-jellyfish
left a comment
There was a problem hiding this comment.
This mostly looks good to me. I tried manually testing and the only potential issue I saw was that in a liveness error, I only saw the inline error on the selfie section, while your screenshots showed it in all 3 places. I'm not sure if that's big enough to block this work, but I thought I would mention it here in case it's unexpected.
Thanks for the review Brittany! As a sanity check, I just retested with |
amirbey
force-pushed
the
amirbey/LG-13009-expected-face-error-msg
branch
from
8214768 to
d717b49
Compare
amirbey
force-pushed
the
amirbey/LG-13009-expected-face-error-msg
branch
from
d717b49 to
130e41c
Compare
* resolve conflict encountered during main rebase * consolidate selfie not_live and poor_quality i18n * update spec key for liveness error message * [skip changelog] * happy linting * remove dup tests and add scenarios * key no longer exists
2 participants
🎫 Ticket
Link to the relevant ticket:
LG-13009
🛠 Summary of changes
Consolidate duplicate messaging for selfie not live and selfie poor quality.
AC-1 error messages already handled
AC 2 for LG-13009 resolved in PR #10450
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
Try taking a photo of yourself again. Make sure your whole face is clear and visible in the photo.is displayedTry taking your photos again. Make sure all of your photos are clear and in focus.is displayed👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
Liveness Failure:
Portrait Match Filure/Liveness Error: