Return a Pii::StateId object from idv_session.pii_from_doc#10523
Merged
Return a Pii::StateId object from idv_session.pii_from_doc#10523
Pii::StateId object from idv_session.pii_from_doc#10523Conversation
zachmargolis
approved these changes
Apr 29, 2024
Previous commits added the `Pii::StateId` data class. This is intended to hold the data that is read from the state ID. This has several advantages over the old approach (holding this data in a Hash): 1. It is immutable so it will error if you try to add data not from the state ID 2. It has defined attributes that are all required so you know what data will be present This commit takes the next step in integrating this tool which is modifying `idv_session#pii_from_doc` to serialize the PII before it is written to the session and then dersialize it into `Pii::StateId` on read. [skip changelog]
jmhooper
force-pushed
the
jmhooper-pii-from-doc-setter
branch
from
5d8d249 to
6cf3dd5
Compare
samathad2023
pushed a commit
that referenced
this pull request
May 11, 2024
Previous commits added the `Pii::StateId` data class. This is intended to hold the data that is read from the state ID. This has several advantages over the old approach (holding this data in a Hash): 1. It is immutable so it will error if you try to add data not from the state ID 2. It has defined attributes that are all required so you know what data will be present This commit takes the next step in integrating this tool which is modifying `idv_session#pii_from_doc` to serialize the PII before it is written to the session and then deserialize it into `Pii::StateId` on read. [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous commits added the
Pii::StateIddata class. This is intended to hold the data that is read from the state ID. This has several advantages over the old approach (holding this data in a Hash):This commit takes the next step in integrating this tool which is modifying
idv_session#pii_from_docto serialize the PII before it is written to the session and then deserialize it intoPii::StateIdon read.