Merged
Conversation
changelog: Internal, reCAPTCHA, Refactor reCAPTCHA validator as form model
kevinsmaster5
approved these changes
May 2, 2024
Contributor
kevinsmaster5
left a comment
kevinsmaster5
left a comment
There was a problem hiding this comment.
Looks good. Tested locally and confirm testing plan expected outcome.
zachmargolis
approved these changes
May 2, 2024
| # @param [Float] score_threshold Minimum value for considering passing result | ||
| # @param [Boolean] evaluated_as_valid Whether result was considered valid | ||
| # @param [String] validator_class Class name of validator | ||
| # @param [String] form_class Class name of form |
Contributor
There was a problem hiding this comment.
I'd consider leaving this so it's easier to track over time?
Contributor
Author
There was a problem hiding this comment.
Normally I'd agree if we were already using this in dashboards or saved queries, but I think this was added primarily as a way to diagnose individual log entries, so I don't know that I'm quite as concerned about backwards compatibility?
Merged
samathad2023
pushed a commit
that referenced
this pull request
May 11, 2024
* Move, rename reCAPTCHA validator as form changelog: Internal, reCAPTCHA, Refactor reCAPTCHA validator as form model * Update more validator references * Disambiguate form variable name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Supports LG-12873
🛠 Summary of changes
Continues refactoring in #10540 to rename and move the current validator service classes as forms.
📜 Testing Plan
Validate that there are no regressions in the expected behavior of reCAPTCHA phone validation.
Configure reCAPTCHA score threshold in
config/application.yml+610491570006