LG-11588: Don't tell users to get another letter when they can't#10534
Merged
LG-11588: Don't tell users to get another letter when they can't#10534
Conversation
changelog: User-Facing Improvements, Identity verification, Don't tell users to request a new verify by mail letter when they can't.
theabrad
approved these changes
May 1, 2024
Contributor
theabrad
left a comment
There was a problem hiding this comment.
LGTM. Tested all the scenarios locally. Worked as intended.
Merged
samathad2023
pushed a commit
that referenced
this pull request
May 11, 2024
) * Don't tell users to get another letter when they can't changelog: User-Facing Improvements, Identity verification, Don't tell users to request a new verify by mail letter when they can't. * Initial crack at ZH translation * Update expected error in feature test * Update another feature test expected error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-11588
🛠 Summary of changes
When users enter an incorrect verification code in the verify by mail code, the error message suggests that they "Please request another letter for a new code."
This PR updates that message to remove that suggestion if the user cannot currently request another GPO letter (either because their most recent request was too recent or they have requested the maximum number of letters). The message is unchanged for users who are still able to request letters.
This change involved adding new translation keys, using adapted versions of the text we already had:
Please request another letter for a new code.Vuelve a solicitar otra carta para recibir un nuevo código.Veuillez solliciter une autre lettre afin d’obtenir un nouveau code.请要求另外一封信来得到新代码。📜 Testing Plan
First, configure your application.yml to test the "must wait 1 day" condition:
Now, configure your application.yml to test the "requested too many letters" condition:
Now configure your application.yml such that the user will not be prevented from requesting a new letter:
👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
Before:
After: