Skip to content

fix(wework): distinguish processing segment phases - #2032

Merged
qdaxb merged 1 commit into
mainfrom
fix/wework-processing-phases
Jul 17, 2026
Merged

qdaxb merged 1 commit into
mainfrom
fix/wework-processing-phases

Conversation

@qdaxb

@qdaxb qdaxb commented Jul 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • distinguish live, intermediate, and final processing segments so narrative text does not produce repeated processed-duration rows
  • keep intermediate segments summarized as called tools while reserving the outer processed collapse for the final segment
  • shimmer the latest live tool row and every running tool status row without animating historical details
  • document the processing timeline behavior in Chinese and English

Verification

  • pnpm --dir wework test --run src/components/chat/blocks/ToolBlocksDisplay.test.tsx
  • pnpm --filter wework typecheck
  • pre-push Wework ESLint, TypeScript, and full unit test suite

Summary by CodeRabbit

  • New Features

    • Added clearer processing timelines with live, intermediate, and final stages.
    • Added expandable final-processing summaries with persisted state.
    • Added tool and file-operation durations, including live shimmer indicators.
  • Improvements

    • Updated activity labels and file-operation messages for clearer status visibility.
    • Improved processing completion tracking and timeline behavior.
  • Documentation

    • Expanded quick-start guidance for tool activity, scrolling, expansion, and processing summaries.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 339835cd-1016-4a2a-aa0d-594a3500a5f1

📥 Commits

Reviewing files that changed from the base of the PR and between dafb8ae and 78d7fce.

📒 Files selected for processing (12)
  • README.md
  • README_zh.md
  • packages/chat-core/src/workbench-message-reducer.ts
  • wework/src/components/chat/MessageList.test.tsx
  • wework/src/components/chat/MessageList.tsx
  • wework/src/components/chat/blocks/ToolBlockItem.test.tsx
  • wework/src/components/chat/blocks/ToolBlockItem.tsx
  • wework/src/components/chat/blocks/ToolBlocksDisplay.test.tsx
  • wework/src/components/chat/blocks/ToolBlocksDisplay.tsx
  • wework/src/components/chat/blocks/processingDuration.ts
  • wework/src/i18n/locales/en/chat.json
  • wework/src/i18n/locales/zh-CN/chat.json

📝 Walkthrough

Walkthrough

Processing blocks now receive completion timestamps consistently. Wework adds phase-aware processing timelines, duration displays, shimmer cues, localized activity labels, and persisted final-processing expansion behavior, with corresponding UI and reducer test updates.

Changes

Processing timeline and tool activity UI

Layer / File(s) Summary
Completion timestamp tracking
packages/chat-core/src/workbench-message-reducer.ts
Processing blocks now record completedAt when transitioning to done or error, including merge and finalization paths.
Tool durations and activity labels
wework/src/components/chat/blocks/processingDuration.ts, wework/src/components/chat/blocks/ToolBlockItem.tsx, wework/src/i18n/locales/*/chat.json
Tool rows display computed durations and shimmer states; activity labels and file-action translations are updated.
Phase-aware processing timeline
wework/src/components/chat/blocks/ToolBlocksDisplay.tsx, wework/src/components/chat/blocks/ToolBlocksDisplay.test.tsx
Processing phases control running state, previews, summary durations, row timing, and latest-row highlighting.
Message-level processing shell
wework/src/components/chat/MessageList.tsx, wework/src/components/chat/MessageList.test.tsx, README*.md
Assistant messages derive processing phases, suppress thinking rows in completed states, persist final-processing expansion per conversation, and document the updated display behavior.

Estimated code review effort: 4 (Complex) | ~45 minutes

Possibly related PRs

Suggested reviewers: ficohu

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/wework-processing-phases

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qdaxb
qdaxb force-pushed the fix/wework-processing-phases branch 6 times, most recently from e2dd151 to b1942f6 Compare July 17, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant