Repository navigation
fix(wework): show thinking between streamed items - #2690
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe runtime now completes active process-text blocks when a different item starts. The chat message list keeps completed process-text blocks visible and shows the ChangesStreaming process-text handling
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to This change restores the thinking indicator between streamed process text and the next runtime item while preserving suppression during active streaming, with regression coverage added; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dab3367 to
086873d
Compare
Summary
Root cause
The frontend hid the global thinking indicator while the trailing process-text block was still marked as streaming. In the failing Codex event order, a new reasoning or final-message item could start before the previous commentary item completed, so the executor left that process-text block streaming and the UI appeared frozen.
Validation
pnpm --filter wework test src/components/chat/MessageList.test.tsx(140 tests passed)cargo test --manifest-path executor/Cargo.toml --all-features --lib runtime_work::events::tests::(46 tests passed)cargo test --manifest-path executor/Cargo.toml --all-features --lib(794 passed, 1 ignored)Summary by CodeRabbit
Bug Fixes
Tests