Skip to content

fix(wework): format tool duration in minutes - #2043

Merged
qdaxb merged 1 commit into
mainfrom
fix/tool-duration-minutes
Jul 18, 2026
Merged

qdaxb merged 1 commit into
mainfrom
fix/tool-duration-minutes

Conversation

@qdaxb

@qdaxb qdaxb commented Jul 18, 2026 •

Copy link
Copy Markdown
Contributor

What changed

  • format the Wework tool summary duration as minutes and seconds after 60 seconds
  • add regression coverage for the 60-second boundary and remaining seconds
  • document the duration display rule in Chinese and English

Why

The tool summary used a whole-seconds-only formatter, so long-running tasks displayed values such as 269 秒 instead of a readable minutes-and-seconds duration.

Validation

  • pnpm --filter wework test -- ToolBlocksDisplay.test.tsx (180 files, 1799 tests passed)
  • Prettier and ESLint checks for changed Wework files
  • pre-push ESLint, TypeScript, and unit tests
  • isolated real-Tauri verification: sleep 70 displayed 1 分 0 秒 at the boundary and 1 分 14 秒 in the captured final state

Summary by CodeRabbit

  • New Features

    • Processing durations of 60 seconds or longer now display in minutes and seconds, such as “1 分 2 秒.”
    • Added clear formatting for the exact 60-second duration.
  • Documentation

    • Updated English and Chinese guides with clearer comparison and task-status tables.
    • Added tool-duration details to execution timelines.
    • Expanded and standardized troubleshooting questions, causes, and solutions.

@coderabbitai

coderabbitai Bot commented Jul 18, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2f5485c2-18ac-484f-bdb1-069df1c97b2a

📥 Commits

Reviewing files that changed from the base of the PR and between fd84d28 and 050b173.

📒 Files selected for processing (4)
  • docs/en/user-guide/coding/managing-code-tasks.md
  • docs/zh/user-guide/coding/managing-code-tasks.md
  • wework/src/components/chat/blocks/ToolBlocksDisplay.test.tsx
  • wework/src/components/chat/blocks/processingDuration.ts

📝 Walkthrough

Walkthrough

The PR changes processing-duration output to minute-and-second formatting at 60 seconds and updates related tests. English and Chinese documentation revise comparison tables, task states, tool-duration descriptions, and troubleshooting sections.

Changes

Task duration and documentation

Layer / File(s) Summary
Minute-and-second duration formatting
wework/src/components/chat/blocks/processingDuration.ts, wework/src/components/chat/blocks/ToolBlocksDisplay.test.tsx
Durations under one minute remain seconds-only; longer durations use minutes and remaining seconds, with coverage for 60 and 62 seconds.
Task-management documentation updates
docs/en/user-guide/coding/managing-code-tasks.md, docs/zh/user-guide/coding/managing-code-tasks.md
Task comparison and state tables, tool-duration descriptions, and common-issue formatting are updated in English and Chinese.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: ficohu

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/tool-duration-minutes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qdaxb
qdaxb marked this pull request as ready for review July 18, 2026 18:20
@qdaxb
qdaxb merged commit 1d927af into main Jul 18, 2026
29 of 30 checks passed
@qdaxb
qdaxb deleted the fix/tool-duration-minutes branch July 18, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant