Repository navigation
fix(wework): keep thinking row visible in tool preview - #2071
Merged
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe live tool activity preview now re-evaluates bottom scrolling when the Thinking row appears or disappears. A regression test covers this transition, and English and Chinese developer guides document the resulting scrolling rules. ChangesTool Preview Scrolling
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Root cause
The inner tool preview only synchronized
scrollTopwhenrows.lengthchanged. Completing a tool and rendering the thinking row can keep the same row count, so that new row was rendered below the visible viewport without updating the inner scrollbar.Impact
During long-running Wework tasks, the current thinking status remains visible after a tool finishes instead of being hidden below the compact three-row tool preview.
Validation
pnpm --filter wework test(183 files, 1840 tests)pnpm --filter wework exec vitest run src/components/chat/blocks/ToolBlocksDisplay.test.tsx(50 tests)Summary by CodeRabbit
Bug Fixes
Tests
Documentation