Repository navigation
fix(wework): show actual file edit durations - #2059
Conversation
|
Important Review skippedNo new commits to review since the last review. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughPer-file edit durations are derived from matching completed edit tools, passed through tool and live preview rendering, and displayed for each changed file. English and Chinese documentation describe the timing boundaries, and tests verify distinct file durations. ChangesPer-file edit duration display
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant ToolBlocksDisplay
participant CompletedEditTools
participant ToolBlockItem
participant FileChangeRows
ToolBlocksDisplay->>CompletedEditTools: collect completed file-edit inputs and timestamps
ToolBlocksDisplay->>ToolBlockItem: pass the per-file duration map
ToolBlockItem->>FileChangeRows: render each matched file duration
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
What changed
Root cause
The rows shown in the conversation come from a
file_changessummary block created at the end of the turn. The UI used that summary block's timestamps, so completed edits were typically displayed as0.0seven when the edit tool had streamed for much longer.Validation
pnpm --filter wework test— 180 files, 1820 tests passedpnpm --filter wework typecheckThe isolated account selected a Kimi model without an edit/apply-patch tool, so that real task could not generate the completed file-edit state. The deterministic component regression covers two completed file edits with distinct
4.3sand6.8sdurations and verifies that0.0sis absent.Summary by CodeRabbit
New Features
Documentation