[ROCm][CI] Cleaning and restructuring amd-ci legacy pipeline#34839
[ROCm][CI] Cleaning and restructuring amd-ci legacy pipeline#34839gshtras merged 80 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
There was a problem hiding this comment.
Code Review
This pull request adds the tensorizer dependency to requirements/rocm-test.txt. This change appears to be a prerequisite for enabling tensorizer-related tests within the ROCm CI pipeline. While the change itself is correct and pins the dependency version, the pull request description details a wide range of CI pipeline restructuring tasks that are not reflected in the provided file changes. To avoid confusion and maintain a clear project history, I recommend updating the pull request description to accurately match the scope of this change.
|
I will first run a nightly with both gfx942 and gfx950 to see if this yaml is ready to be merged. I did not use AI at all for this so I want to be sure 😅 |
| # favor of new tests in fusions_e2e. We avoid replicating the new jobs in # | ||
| # this file as it's deprecated. # | ||
| # # | ||
| ##################################################################################################################################### |
There was a problem hiding this comment.
This will get outdated very quickly. Is this necessary? Can this TODO information be kept elsewhere? Maybe just put the TODO someplace else and then have a link pointing to it?
There was a problem hiding this comment.
Having a TODO list and updating as we optimize our CI is a good idea. So I'm thinking that it's better here.
There was a problem hiding this comment.
After internal discussion, we decided to move the TODO list in an umbrella issue focused entirely on ROCm CI: #34994
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
|
This pull request has merge conflicts that must be resolved before it can be |
…infra Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
…4994 Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
…infra Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
|
This pull request has merge conflicts that must be resolved before it can be |
…infra Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
TODOsin an isolated sectionNOTESin an isolated sectiontentativelabelUPDATE (3/8/2026):
UPDATE (3/13/2026):
tentativelabel as it is useful for fast testing inamd-cisignalcc @kenroche