Skip to content

[ROCm][CI] Cleaning and restructuring amd-ci legacy pipeline#34839

Merged
gshtras merged 80 commits intovllm-project:mainfrom
ROCm:akaratza_feat_labels_infra
Mar 19, 2026
Merged

[ROCm][CI] Cleaning and restructuring amd-ci legacy pipeline#34839
gshtras merged 80 commits intovllm-project:mainfrom
ROCm:akaratza_feat_labels_infra

Conversation

@AndreasKaratzas
Copy link
Collaborator

@AndreasKaratzas AndreasKaratzas commented Feb 18, 2026

  • Moved TODOs in an isolated section
  • Moved NOTES in an isolated section
  • Removed unnecessary comments
  • Updated test tags with current hardware targets
  • Added nightly and agent pool-specific tags
  • Removed custom test template
  • Removed dead code (e.g., blackwell tests) and clarified the gfx950 tests that AMD team is going to implement to match blackwell tests
  • Updated blocking label
  • Updated timeouts
  • Ordered each test group yaml key uniformly
  • Removed unnecessary tentative label

UPDATE (3/8/2026):

UPDATE (3/13/2026):

  • Anticipating:
  • Removed redundancies:
    • Deduplicated MI250, MI325, and MI355 and now each platform is going to run tests that are checking better the platform integrity.
    • There are still some seemingly hardware-agnostic tests that all 3 platforms share but that is because they provide big coverage regarding overall platform correctness and functionality integrity.
  • Brought back the tentative label as it is useful for fast testing in amd-ci signal
  • Updated source file dependencies to reduce the number of tests PRs request (following @okakarpa advice)

cc @kenroche

Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
@mergify mergify bot added ci/build rocm Related to AMD ROCm labels Feb 18, 2026
@github-project-automation github-project-automation bot moved this to Todo in AMD Feb 18, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the tensorizer dependency to requirements/rocm-test.txt. This change appears to be a prerequisite for enabling tensorizer-related tests within the ROCm CI pipeline. While the change itself is correct and pins the dependency version, the pull request description details a wide range of CI pipeline restructuring tasks that are not reflected in the provided file changes. To avoid confusion and maintain a clear project history, I recommend updating the pull request description to accurately match the scope of this change.

@AndreasKaratzas
Copy link
Collaborator Author

I will first run a nightly with both gfx942 and gfx950 to see if this yaml is ready to be merged. I did not use AI at all for this so I want to be sure 😅

@AndreasKaratzas
Copy link
Collaborator Author

# favor of new tests in fusions_e2e. We avoid replicating the new jobs in #
# this file as it's deprecated. #
# #
#####################################################################################################################################
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will get outdated very quickly. Is this necessary? Can this TODO information be kept elsewhere? Maybe just put the TODO someplace else and then have a link pointing to it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a TODO list and updating as we optimize our CI is a good idea. So I'm thinking that it's better here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After internal discussion, we decided to move the TODO list in an umbrella issue focused entirely on ROCm CI: #34994

@mergify
Copy link

mergify bot commented Feb 19, 2026

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @AndreasKaratzas.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Feb 19, 2026
…infra

Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
@mergify mergify bot removed the needs-rebase label Feb 20, 2026
…4994

Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
…infra

Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
@mergify mergify bot removed the needs-rebase label Mar 18, 2026
@mergify
Copy link

mergify bot commented Mar 19, 2026

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @AndreasKaratzas.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Mar 19, 2026
…infra

Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
@mergify mergify bot removed the needs-rebase label Mar 19, 2026
@gshtras gshtras merged commit 040a505 into vllm-project:main Mar 19, 2026
22 of 23 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in AMD Mar 19, 2026
@gshtras gshtras deleted the akaratza_feat_labels_infra branch March 19, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build kv-connector ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm v1

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants