[ROCm][CI] Guard CudaPlatform/RocmPlatform imports to fix test collection on cross-platform builds#37617
Merged
DarkLight1337 merged 5 commits intovllm-project:mainfrom Mar 21, 2026
Merged
Conversation
…tion on cross-platform builds Signed-off-by: Andreas Karatzas <akaratza@amd.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request effectively guards against CudaPlatform and RocmPlatform import errors on cross-platform builds by using try-except blocks and conditionally skipping tests when these platforms are not available. This significantly improves the robustness of the test suite in diverse build environments. The changes are well-implemented and align with the stated motivation.
AndreasKaratzas
added
the
ready
Collaborator
Author
|
Testing MI355 to see if issue is resolved (added |
…_attention for ROCM_ATTN Signed-off-by: Andreas Karatzas <akaratza@amd.com>
…ted head size Signed-off-by: Andreas Karatzas <akaratza@amd.com>
AndreasKaratzas
requested review from
WoosukKwon,
mgoin,
tlrmchlsmth and
yewentao256
as code owners
Collaborator
Author
DarkLight1337
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for:
Fixes unconditionally imports
CudaPlatformandRocmPlatformat module level. Addresses failure inmi355_1: Kernels (B200-MI355)Motivation: https://buildkite.com/vllm/amd-ci/builds/6701/steps/canvas?sid=019d07a7-1ac3-4614-993f-cc80ab9b2c57&tab=output
cc @kenroche