[ROCm][CI] Update GSM8K eval config to use fp8-and-mixed models list#37619
Merged
DarkLight1337 merged 1 commit intovllm-project:mainfrom Mar 20, 2026
Merged
Conversation
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the GSM8K evaluation configuration in the AMD CI pipeline to use a new list of models, including FP8 and mixed-precision models, to address a CI failure. However, I've identified a critical issue with the file path for the new model list in the CI configuration. The specified path does not match the file's actual location, which will cause the CI job to fail. My review includes a suggested fix for this path.
AndreasKaratzas
added
the
ready
Collaborator
Author
|
Testing MI325 to see if issue is resolved (added |
Collaborator
Author
|
Test group confirmed passing: https://buildkite.com/vllm/amd-ci/builds/6713/steps/canvas?sid=019d089d-d56c-44a2-9653-5cb39be5b9f4&tab=output |
DarkLight1337
approved these changes
Mar 20, 2026
chooper26
pushed a commit
to intellistream/vllm-hust
that referenced
this pull request
Mar 21, 2026
…llm-project#37619) Signed-off-by: Andreas Karatzas <akaratza@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for:
Updated the GSM8K correctness eval in the AMD CI pipeline to use the
models-mi3xx-fp8-and-mixed.txtconfig list instead ofmodels-mi3xx-fp8.txt. Addresses failure inmi325_2: LM Eval Small Models (B200-MI325)Motivation: https://buildkite.com/vllm/amd-ci/builds/6701/steps/canvas?sid=019d07a7-1a87-47bb-866e-99e0fb04c660&tab=output
cc @kenroche