Skip to content

[CI/Build] Split out MM pooling tests#37542

Merged
DarkLight1337 merged 5 commits intovllm-project:mainfrom
DarkLight1337:mm-pooling
Mar 19, 2026
Merged

[CI/Build] Split out MM pooling tests#37542
DarkLight1337 merged 5 commits intovllm-project:mainfrom
DarkLight1337:mm-pooling

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Mar 19, 2026

Purpose

Run MM extended pooling tests separate from MM extended 1 to speed up CI

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 added rocm Related to AMD ROCm ready ONLY add when PR is ready to merge/full CI is needed labels Mar 19, 2026
@github-project-automation github-project-automation bot moved this to Todo in AMD Mar 19, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the multi-modal model tests in the CI configuration by splitting the extended tests into 'generation' and 'pooling' suites. This improves granularity and clarity of the test jobs. The changes in .buildkite/test-amd.yaml and .buildkite/test_areas/models_multimodal.yaml correctly partition the test runs and update dependencies. However, I've noticed a potentially critical oversight in the new 'pooling' test jobs where a dependency installation seems to be missing. Please see my detailed comments.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 19, 2026 09:45
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 merged commit c7bc12c into vllm-project:main Mar 19, 2026
20 of 21 checks passed
@DarkLight1337 DarkLight1337 deleted the mm-pooling branch March 19, 2026 11:36
@github-project-automation github-project-automation bot moved this from Todo to Done in AMD Mar 19, 2026
fxdawnn pushed a commit to fxdawnn/vllm that referenced this pull request Mar 19, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
AndreasKaratzas added a commit to ROCm/vllm that referenced this pull request Mar 19, 2026
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
chooper26 pushed a commit to intellistream/vllm-hust that referenced this pull request Mar 21, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants