[CI/Build] Split out MM pooling tests#37542
Merged
DarkLight1337 merged 5 commits intovllm-project:mainfrom Mar 19, 2026
Merged
Conversation
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Isotr0py
approved these changes
Mar 19, 2026
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the multi-modal model tests in the CI configuration by splitting the extended tests into 'generation' and 'pooling' suites. This improves granularity and clarity of the test jobs. The changes in .buildkite/test-amd.yaml and .buildkite/test_areas/models_multimodal.yaml correctly partition the test runs and update dependencies. However, I've noticed a potentially critical oversight in the new 'pooling' test jobs where a dependency installation seems to be missing. Please see my detailed comments.
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
noooop
approved these changes
Mar 19, 2026
fxdawnn
pushed a commit
to fxdawnn/vllm
that referenced
this pull request
Mar 19, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
AndreasKaratzas
added a commit
to ROCm/vllm
that referenced
this pull request
Mar 19, 2026
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
chooper26
pushed a commit
to intellistream/vllm-hust
that referenced
this pull request
Mar 21, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Run MM extended pooling tests separate from MM extended 1 to speed up CI
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.