[ROCm][CI] Add large_gpu_mark to test_max_tokens_none for ROCm#37717
Open
AndreasKaratzas wants to merge 1 commit intovllm-project:mainfrom
Open
[ROCm][CI] Add large_gpu_mark to test_max_tokens_none for ROCm#37717AndreasKaratzas wants to merge 1 commit intovllm-project:mainfrom
AndreasKaratzas wants to merge 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
AndreasKaratzas
added
ready
Collaborator
Author
|
Testing MI250 to see if issue is resolved (added |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request effectively addresses the CI failure on ROCm platforms by introducing the large_gpu_mark to the test_max_tokens_none test. This ensures that the test is only run on environments with sufficient GPU memory, improving the reliability and accuracy of the test suite. The implementation is clean and correctly leverages pytest.mark.parametrize for conditional marking based on the platform.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for:
Marks
max_tokenstest withdistilbert/distilgpt2as a large GPU test. Addresses failure inmi250_1: RegressionMotivation: https://buildkite.com/vllm/amd-ci/builds/6721/steps/canvas?sid=019d09d4-708e-44b0-a0d0-ccf0e3c00a94&tab=output
cc @kenroche