[ROCm][CI] Stabilize ROCm speech-to-text translation test with ROCM_EXTRA_ARGS#37723
Draft
AndreasKaratzas wants to merge 1 commit intovllm-project:mainfrom
Draft
[ROCm][CI] Stabilize ROCm speech-to-text translation test with ROCM_EXTRA_ARGS#37723AndreasKaratzas wants to merge 1 commit intovllm-project:mainfrom
AndreasKaratzas wants to merge 1 commit intovllm-project:mainfrom
Conversation
…XTRA_ARGS Signed-off-by: Andreas Karatzas <akaratza@amd.com>
AndreasKaratzas
added
ready
Collaborator
Author
|
Testing MI355 to see if issue is resolved (added |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to stabilize ROCm speech-to-text translation tests by incorporating ROCM_EXTRA_ARGS into the server arguments. This adds flags to disable prefix caching and limit the max number of sequences to 1 on ROCm platforms, which is a common strategy to improve test determinism. The implementation is straightforward and appears correct for the intended purpose. I have no further suggestions.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for:
Stabilizes whisper tests with
ROCM_EXTRA_ARGSon MI355. Addresses failure inmi355_1: Entrypoints Integration (API Server 1)Motivation: https://buildkite.com/vllm/amd-ci/builds/6721/steps/canvas?sid=019d09d4-711d-4fbe-9f40-6ec17a28f286&tab=output
cc @kenroche