Repository navigation
[cherry-pick][release/v0.32.0] Backport 18 bugfixes for milestone issues (batch 7) - #9470
Conversation
… error (vllm-project#8450) Signed-off-by: Wenbo Ji <36562829+fusheng-ji@users.noreply.github.com> (cherry picked from commit 150bcf5)
Signed-off-by: NumberWan <wantszkin2003@gmail.com> (cherry picked from commit d689720)
…from parsed CLI args (vllm-project#8041) Signed-off-by: Binbin Zhang <binbin36520@gmail.com> (cherry picked from commit 7147cb9)
…ing (vllm-project#9056) Signed-off-by: RyanYun09 <ryanyun0911@gmail.com> (cherry picked from commit bf98347)
…ining vision SDPA (vllm-project#9386) Signed-off-by: amy-why-3459 <wuhaiyan17@huawei.com> (cherry picked from commit 3ca10fb)
…mpty_intermediate_tensors (vllm-project#6860) Signed-off-by: rk9595 <rakesh.kariya@somaiya.edu> Signed-off-by: Rakesh Kariya <rakesh.kariya@somaiya.edu> (cherry picked from commit a46f860)
…ch CLI (vllm-project#9322) (cherry picked from commit b9f93ed)
…rom_cli_args (vllm-project#8585) Signed-off-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com> Signed-off-by: Gao Han <hgaoaf@connect.ust.hk> Co-authored-by: Gao Han <hgaoaf@connect.ust.hk> (cherry picked from commit 934a3ab)
…roject#8891) Signed-off-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com> Signed-off-by: knlnguyen1802 <knlnguyen1802@gmail.com> Signed-off-by: SamitHuang <285365963@qq.com> Signed-off-by: Yueqian Lin <linyueqian@outlook.com> Co-authored-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com> Co-authored-by: SamitHuang <285365963@qq.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Gao Han <hgaoaf@connect.ust.hk> Co-authored-by: Yueqian Lin <linyueqian@outlook.com> (cherry picked from commit 8649e99)
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
amy-why-3459
left a comment
There was a problem hiding this comment.
Review (core logic; 82-file cherry-pick batch)
Seventh release/v0.32.0 backport batch. Scoped this pass to the production engine / entrypoint / duplex / diffusion-LoRA / model-guard paths plus the documented conflict adaptations — not a line-by-line re-audit of every test asset.
Covered
- Engine queue / pause (#8891 / #8450): frontend puts go through the orchestrator loop (
orchestrator_loop+_put_request_queue*) instead of blocking onsync_q.put; never-admitted enqueue failures reset the frontend MM cache, while half-enqueued groups leave the cache alone so orphan revoke can finish. Streaming updates share the same cancellable path. - Artifact dirs: client-supplied
REQUEST_ARTIFACT_DIRS_KEYis stripped before the transform; cleanup uses server-tracked dirs only — matches the path-injection hardening intent. - Duplex history (#8691): materialize-on-read + truncation cursors /
item_truncation_sourceslook coherent; pending audio-text marks stay O(delta) until materialization; native SignalTurn truncate now records the same cursor as the control path. - Diffusion LoRA / MoE (#9443):
_ensure_moe_lora_contextat init, republish on activate / deactivate / rollback, and mapping derived from_active_adapter_idaddress the silent no-LoRA MoE path. - MoT GEMM (#6490): one-sided bias acceptance is consistent with the reported rejection bug.
- Engine-args / stage projection (#8041 / #8585 / #9404): diffusion parallel knobs preserved across
from_cli_args; LLM stages still exclude diffusion-only load knobs (incl.enable_broadcast_weight_load); oversized stage-budget rejection on integrated GPUs is present. - Model guards: CosyVoice3 unsupported-API / prefill embed guard (#4738), VoxCPM2 outer full-cudagraph reject (#9458), Qwen2.5-Omni talker span assembly from runner phase metadata (#5019), MiniCPM-o CUDA Thinker
TRITON_ATTNpin for reference-audio parity (#9386). - Bench / eval:
_gt_referencesmatches Omni-DuplexEval empty/dedupe semantics (#9056); goodput validatesaudio_ttfp(not the oldaudio_ttfttypo) and treats0.0as unmeasured for non-duplex backends (#9322). - Backport adaptations in the PR body (drop foreign tests from #8943/#9346; drop #9386 docs/fish hunks not on release) look correctly scoped.
Non-blocking notes
- Large surface (engine + duplex + LoRA + several model guards). Release CI on this branch remains the real integration gate for cross-pick interactions that unit tests cannot catch in isolation.
#8891parking through partial wakes depends on abort/cancel releasing admission slots as described — worth watching pause/resume + duplex load in release CI for any residual wedge symptoms.- MoE LoRA publish-after-commit is easy to regress if a future change mutates
_active_adapter_idordering; the added tests look like the right lock.
No blockers spotted in the core paths reviewed here.
|
This PR appears to belong to: docs/design/module/ar_runtime.md, docs/design/module/entrypoints.md, docs/design/module/diffusion/index.md. Module owners: @david6666666 @Isotr0py @princepride Routing: @david6666666 via module named in the PR description; @Isotr0py via module named in the PR description; @princepride via module named in the PR description @tzhouam, please review your own changes and leave a short self-review comment describing what you checked. PRs without author self-review may not be assigned a reviewer. Please take a look when you have a chance. If you would like an automated review, mention @vllm-omni-review-bot in a comment. |
Omni ReviewBot triage noteAutomated triage of commit
These are automated triage suggestions only — the final decision belongs to the maintainers. |
Signed-off-by: lm10-arg <347490427+lm10-arg@users.noreply.github.com> Co-authored-by: lm10-arg <347490427+lm10-arg@users.noreply.github.com> (cherry picked from commit 255f0d8)
Signed-off-by: lm10-arg <347490427+lm10-arg@users.noreply.github.com> Co-authored-by: lm10-arg <347490427+lm10-arg@users.noreply.github.com> (cherry picked from commit 6376954)
…ta (vllm-project#5019) Signed-off-by: LJX-xixi <lijinxi413@icloud.com> Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 6bcfc4d)
…ndaries (vllm-project#8691) Signed-off-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com> Signed-off-by: natureofnature <wzliu@connect.hku.hk> Signed-off-by: Gao Han <hgaoaf@connect.ust.hk> Co-authored-by: natureofnature <wzliu@connect.hku.hk> Co-authored-by: Gao Han <hgaoaf@connect.ust.hk> (cherry picked from commit 8c0de61)
…lm-project#6490) Signed-off-by: Yash Jain <yashjainjain1704@gmail.com> (cherry picked from commit 4daeba8)
…-project#9458) Signed-off-by: Yueqian Lin <linyueqian@outlook.com> (cherry picked from commit af1ced6)
Signed-off-by: zzh <943967662@qq.com> (cherry picked from commit 742356a)
…fill embeddings (vllm-project#4738) Signed-off-by: ssfdgsg <487720673@qq.com> Signed-off-by: ssfdgsg <15728525+ssfdgsg@user.noreply.gitee.com> Co-authored-by: ssfdgsg <15728525+ssfdgsg@user.noreply.gitee.com> (cherry picked from commit ee37ec0)
5af7827 to
56aa11c
Compare
amy-why-3459
left a comment
There was a problem hiding this comment.
Delta review (56aa11c0, Revision 2)
Tip moved after the first pass (5af78273): Revision 2 inserts #9371 and #9389 ahead of #5019 so the talker-preprocess tests that expect EOS/pad end-conditioning rows actually match the release tree. Re-checked the new dependency picks plus a spot check that prior core coverage still holds on the rewritten tip.
Covered this pass
- #9371 talker end conditioning: end-of-span EOS/pad rows are assembled for the talker path; new
test_qwen2_5_omni_talker_conditioning.pypins the contract the #5019 preprocess cases assume. - #9389 speaker fixture: speaker-test fixture fix is a small companion so the Qwen2.5-Omni speaker tests stay green on release; no production behavior change beyond the fixture.
- #5019 ordering: with #9371/#9389 ahead of it, the talker span-from-phase-metadata pick should no longer trip the six preprocess failures called out in the Revision 2 note.
- Spot-checked that engine queue/pause (#8891), duplex materialize-on-read (#8691), MoE LoRA context (#9443), MoT one-sided bias (#6490), CosyVoice3 / VoxCPM2 guards, and the documented backport adaptations remain present on the new tip.
Non-blocking
- Large surface still; release CI on this branch remains the real integration gate for cross-pick interactions.
- Same note as before on #8891 parking through partial wakes — watch pause/resume + duplex load in release CI.
No blockers spotted in the Revision 2 delta.
Purpose
Seventh cherry-pick batch for
release/v0.32.0(follows #9206, #9251, #9295, #9334, #9352, #9394; batch 6 is #9397). Base:ab216c0b.Scope: bugfix PRs merged to
mainthat close v0.32.0 milestone / Outstanding-DI dashboard bugs, plus the milestone-tagged CI dependency #9393. Audited every bugfix/CI/doc PR merged tomainsince the branch cut against release history, merged batches and the open release PRs (#9397, #9377, #9335, #9381).Included (
git cherry-pick -x, main merge order)OmniEngineArgs.from_cli_argssilently drops OrchestratorArgs-owned diffusion engine args (library path) #8503)OmniEngineArgs.from_cli_argssilently drops OrchestratorArgs-owned diffusion engine args (library path) #8503)Backport adaptations (conflicts were only with main-only context)
Revision 2: the first CI run failed 6 cases in
tests/model_executor/models/qwen2_5_omni/test_qwen2_5_omni_talker_preprocess.py([Bugfix] Qwen2.5-Omni: assemble talker spans from runner phase metadata #5019) because [Bugfix] Qwen2.5-Omni: assemble talker spans from runner phase metadata #5019 was written on top of [Bugfix] Fix Qwen2.5-Omni talker end conditioning #9371, which was not on release. Added [Bugfix] Fix Qwen2.5-Omni talker end conditioning #9371 and [Bugfix] Fix Qwen2.5-Omni speaker test fixture #9389 before [Bugfix] Qwen2.5-Omni: assemble talker spans from runner phase metadata #5019.[Bugfix] Preserve the diffusion parallel knobs when engine args come from parsed CLI args #8041, [Bugfix][Engine] Preserve non-parallel diffusion engine args across from_cli_args #8585, [Bugfix] CosyVoice3: reject unsupported generation APIs and guard prefill embeddings #4738:
tests/engine/test_arg_utils.py/tests/worker_v2/test_omni_model_state.pyconflicted because the upstream hunks carried neighbouring tests from [OOT] [vllm-metal] Add external CustomOp registration [1/3] #8943 and [Refactor] Retire the generic deferred MTP path in MRV2 #9346, which are not on the release branch. Kept only each PR's own additions; dropped the foreign tests.[Bugfix] Align MiniCPM-o reference audio with Transformers while retaining vision SDPA #9386: dropped the
docs/serving/realtime_duplex_api.mdandtests/model_executor/models/fish_omni/test_fish_omni_config.pyhunks. Both edit content introduced by [Docs] Clarify MiniCPM-o attention backend comparisons #9344 and a later fish-omni commit that are not on release; the MiniCPM-o fix itself (other 25 files) is unchanged.Upstream authors, sign-offs and source SHAs are preserved.
Not included
.buildkite/amd/*), ROCm/NPU nightly additions.Test Plan
ruff check/ruff format --checkon all 66 changed Python files: clean.tests/worker_v2/test_omni_model_state.pynon-cosyvoice3 cases pass (63), the remaining failures areImportError: MultiModalDummyOptionsfrom the vLLM version gap, not from these picks.