Skip to content

[cherry-pick][release/v0.32.0] Backport 18 bugfixes for milestone issues (batch 7) - #9470

Merged
tzhouam merged 18 commits into
vllm-project:release/v0.32.0from
tzhouam:cherry-pick/release-v0.32.0-batch7
Oct 27, 2026
Merged

tzhouam merged 18 commits into
vllm-project:release/v0.32.0from
tzhouam:cherry-pick/release-v0.32.0-batch7

Conversation

@tzhouam

@tzhouam tzhouam commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Purpose

Seventh cherry-pick batch for release/v0.32.0 (follows #9206, #9251, #9295, #9334, #9352, #9394; batch 6 is #9397). Base: ab216c0b.

Scope: bugfix PRs merged to main that close v0.32.0 milestone / Outstanding-DI dashboard bugs, plus the milestone-tagged CI dependency #9393. Audited every bugfix/CI/doc PR merged to main since the branch cut against release history, merged batches and the open release PRs (#9397, #9377, #9335, #9381).

Included (git cherry-pick -x, main merge order)

Backport adaptations (conflicts were only with main-only context)

Upstream authors, sign-offs and source SHAs are preserved.

Not included

Test Plan

  • ruff check / ruff format --check on all 66 changed Python files: clean.
  • Local pytest is limited to vLLM 0.30 on this machine; tests/worker_v2/test_omni_model_state.py non-cosyvoice3 cases pass (63), the remaining failures are ImportError: MultiModalDummyOptions from the vLLM version gap, not from these picks.
  • PR CI on this branch.

fusheng-ji and others added 10 commits October 27, 2026 15:34
… error (vllm-project#8450)

Signed-off-by: Wenbo Ji <36562829+fusheng-ji@users.noreply.github.com>
(cherry picked from commit 150bcf5)
Signed-off-by: NumberWan <wantszkin2003@gmail.com>
(cherry picked from commit d689720)
…ect#9404)

Signed-off-by: tzhouam <tzhouam@connect.ust.hk>
(cherry picked from commit ad3a730)
…from parsed CLI args (vllm-project#8041)

Signed-off-by: Binbin Zhang <binbin36520@gmail.com>
(cherry picked from commit 7147cb9)
…ing (vllm-project#9056)

Signed-off-by: RyanYun09 <ryanyun0911@gmail.com>
(cherry picked from commit bf98347)
…ining vision SDPA (vllm-project#9386)

Signed-off-by: amy-why-3459 <wuhaiyan17@huawei.com>
(cherry picked from commit 3ca10fb)
…mpty_intermediate_tensors (vllm-project#6860)

Signed-off-by: rk9595 <rakesh.kariya@somaiya.edu>
Signed-off-by: Rakesh Kariya <rakesh.kariya@somaiya.edu>
(cherry picked from commit a46f860)
…rom_cli_args (vllm-project#8585)

Signed-off-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com>
Signed-off-by: Gao Han <hgaoaf@connect.ust.hk>
Co-authored-by: Gao Han <hgaoaf@connect.ust.hk>
(cherry picked from commit 934a3ab)
…roject#8891)

Signed-off-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com>
Signed-off-by: knlnguyen1802 <knlnguyen1802@gmail.com>
Signed-off-by: SamitHuang <285365963@qq.com>
Signed-off-by: Yueqian Lin <linyueqian@outlook.com>
Co-authored-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com>
Co-authored-by: SamitHuang <285365963@qq.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Gao Han <hgaoaf@connect.ust.hk>
Co-authored-by: Yueqian Lin <linyueqian@outlook.com>
(cherry picked from commit 8649e99)
@tzhouam tzhouam added this to the v0.32.0 milestone Oct 27, 2026
@tzhouam tzhouam added the ready label to trigger buildkite CI label Oct 27, 2026
@tzhouam
tzhouam requested a review from SamitHuang as a code owner October 27, 2026 07:43
@tzhouam tzhouam added the high priority high priority issue, needs to be done asap label Oct 27, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-27T07:43:32.132697Z
We couldn’t complete this review. Comment @codex review to try again.
5af7827 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@amy-why-3459 amy-why-3459 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review (core logic; 82-file cherry-pick batch)

Seventh release/v0.32.0 backport batch. Scoped this pass to the production engine / entrypoint / duplex / diffusion-LoRA / model-guard paths plus the documented conflict adaptations — not a line-by-line re-audit of every test asset.

Covered

  • Engine queue / pause (#8891 / #8450): frontend puts go through the orchestrator loop (orchestrator_loop + _put_request_queue*) instead of blocking on sync_q.put; never-admitted enqueue failures reset the frontend MM cache, while half-enqueued groups leave the cache alone so orphan revoke can finish. Streaming updates share the same cancellable path.
  • Artifact dirs: client-supplied REQUEST_ARTIFACT_DIRS_KEY is stripped before the transform; cleanup uses server-tracked dirs only — matches the path-injection hardening intent.
  • Duplex history (#8691): materialize-on-read + truncation cursors / item_truncation_sources look coherent; pending audio-text marks stay O(delta) until materialization; native SignalTurn truncate now records the same cursor as the control path.
  • Diffusion LoRA / MoE (#9443): _ensure_moe_lora_context at init, republish on activate / deactivate / rollback, and mapping derived from _active_adapter_id address the silent no-LoRA MoE path.
  • MoT GEMM (#6490): one-sided bias acceptance is consistent with the reported rejection bug.
  • Engine-args / stage projection (#8041 / #8585 / #9404): diffusion parallel knobs preserved across from_cli_args; LLM stages still exclude diffusion-only load knobs (incl. enable_broadcast_weight_load); oversized stage-budget rejection on integrated GPUs is present.
  • Model guards: CosyVoice3 unsupported-API / prefill embed guard (#4738), VoxCPM2 outer full-cudagraph reject (#9458), Qwen2.5-Omni talker span assembly from runner phase metadata (#5019), MiniCPM-o CUDA Thinker TRITON_ATTN pin for reference-audio parity (#9386).
  • Bench / eval: _gt_references matches Omni-DuplexEval empty/dedupe semantics (#9056); goodput validates audio_ttfp (not the old audio_ttft typo) and treats 0.0 as unmeasured for non-duplex backends (#9322).
  • Backport adaptations in the PR body (drop foreign tests from #8943/#9346; drop #9386 docs/fish hunks not on release) look correctly scoped.

Non-blocking notes

  1. Large surface (engine + duplex + LoRA + several model guards). Release CI on this branch remains the real integration gate for cross-pick interactions that unit tests cannot catch in isolation.
  2. #8891 parking through partial wakes depends on abort/cancel releasing admission slots as described — worth watching pause/resume + duplex load in release CI for any residual wedge symptoms.
  3. MoE LoRA publish-after-commit is easy to regress if a future change mutates _active_adapter_id ordering; the added tests look like the right lock.

No blockers spotted in the core paths reviewed here.

@vllm-omni-review-bot

Copy link
Copy Markdown

This PR appears to belong to: docs/design/module/ar_runtime.md, docs/design/module/entrypoints.md, docs/design/module/diffusion/index.md.

Module owners: @david6666666 @Isotr0py @princepride

Routing: @david6666666 via module named in the PR description; @Isotr0py via module named in the PR description; @princepride via module named in the PR description

@tzhouam, please review your own changes and leave a short self-review comment describing what you checked. PRs without author self-review may not be assigned a reviewer.

Please take a look when you have a chance. If you would like an automated review, mention @vllm-omni-review-bot in a comment.

@vllm-omni-review-bot

vllm-omni-review-bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Omni ReviewBot triage note

Automated triage of commit 56aa11c085e4 produced:

  • Priority: high. Prompt maintainer attention is suggested.

These are automated triage suggestions only — the final decision belongs to the maintainers.

@tzhouam
tzhouam enabled auto-merge (squash) October 27, 2026 07:52
@tzhouam
tzhouam disabled auto-merge October 27, 2026 07:54
lm10-arg and others added 8 commits October 27, 2026 16:25
Signed-off-by: lm10-arg <347490427+lm10-arg@users.noreply.github.com>
Co-authored-by: lm10-arg <347490427+lm10-arg@users.noreply.github.com>
(cherry picked from commit 255f0d8)
Signed-off-by: lm10-arg <347490427+lm10-arg@users.noreply.github.com>
Co-authored-by: lm10-arg <347490427+lm10-arg@users.noreply.github.com>
(cherry picked from commit 6376954)
…ta (vllm-project#5019)

Signed-off-by: LJX-xixi <lijinxi413@icloud.com>
Co-authored-by: Claude <noreply@anthropic.com>
(cherry picked from commit 6bcfc4d)
…ndaries (vllm-project#8691)

Signed-off-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com>
Signed-off-by: natureofnature <wzliu@connect.hku.hk>
Signed-off-by: Gao Han <hgaoaf@connect.ust.hk>
Co-authored-by: natureofnature <wzliu@connect.hku.hk>
Co-authored-by: Gao Han <hgaoaf@connect.ust.hk>
(cherry picked from commit 8c0de61)
…lm-project#6490)

Signed-off-by: Yash Jain <yashjainjain1704@gmail.com>
(cherry picked from commit 4daeba8)
…-project#9458)

Signed-off-by: Yueqian Lin <linyueqian@outlook.com>
(cherry picked from commit af1ced6)
Signed-off-by: zzh <943967662@qq.com>
(cherry picked from commit 742356a)
…fill embeddings (vllm-project#4738)

Signed-off-by: ssfdgsg <487720673@qq.com>
Signed-off-by: ssfdgsg <15728525+ssfdgsg@user.noreply.gitee.com>
Co-authored-by: ssfdgsg <15728525+ssfdgsg@user.noreply.gitee.com>
(cherry picked from commit ee37ec0)
@tzhouam
tzhouam force-pushed the cherry-pick/release-v0.32.0-batch7 branch from 5af7827 to 56aa11c Compare October 27, 2026 08:31
@tzhouam tzhouam changed the title [cherry-pick][release/v0.32.0] Backport 16 milestone bugfixes (batch 7) [cherry-pick][release/v0.32.0] Backport 18 bugfixes for milestone issues (batch 7) Oct 27, 2026

@amy-why-3459 amy-why-3459 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delta review (56aa11c0, Revision 2)

Tip moved after the first pass (5af78273): Revision 2 inserts #9371 and #9389 ahead of #5019 so the talker-preprocess tests that expect EOS/pad end-conditioning rows actually match the release tree. Re-checked the new dependency picks plus a spot check that prior core coverage still holds on the rewritten tip.

Covered this pass

  • #9371 talker end conditioning: end-of-span EOS/pad rows are assembled for the talker path; new test_qwen2_5_omni_talker_conditioning.py pins the contract the #5019 preprocess cases assume.
  • #9389 speaker fixture: speaker-test fixture fix is a small companion so the Qwen2.5-Omni speaker tests stay green on release; no production behavior change beyond the fixture.
  • #5019 ordering: with #9371/#9389 ahead of it, the talker span-from-phase-metadata pick should no longer trip the six preprocess failures called out in the Revision 2 note.
  • Spot-checked that engine queue/pause (#8891), duplex materialize-on-read (#8691), MoE LoRA context (#9443), MoT one-sided bias (#6490), CosyVoice3 / VoxCPM2 guards, and the documented backport adaptations remain present on the new tip.

Non-blocking

  1. Large surface still; release CI on this branch remains the real integration gate for cross-pick interactions.
  2. Same note as before on #8891 parking through partial wakes — watch pause/resume + duplex load in release CI.

No blockers spotted in the Revision 2 delta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

high priority high priority issue, needs to be done asap ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.