Repository navigation
[Bugfix][ROCm] Make Qwen OOM recovery pressure deterministic - #9425
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
This PR matches CODEOWNERS paths: /tests/. Code owners: @NickCao @yenuo26 Routing: @NickCao via CODEOWNERS; @yenuo26 via CODEOWNERS @hacZ17, please review your own changes and leave a short self-review comment describing what you checked. PRs without author self-review may not be assigned a reviewer. Please take a look when you have a chance. If you would like an automated review, mention @vllm-omni-review-bot in a comment. |
Omni ReviewBot triage noteAutomated triage of commit
These are automated triage suggestions only — the final decision belongs to the maintainers. |
ef22e8d to
8614ce5
Compare
Omni ReviewBot: supersededThe CI failure noted on |
The recovery scenario used the default graph server, so HIP requests could succeed from captured pools while the sidecar held device memory. Select the OOM server set, which forces eager execution on the declared HIP stages and leaves CUDA and models without those stages unchanged. Signed-off-by: haic0 <149741444+haic0@users.noreply.github.com> Co-authored-by: Grok 4.7 <noreply@x.ai> Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: lm10-arg <347490427+lm10-arg@users.noreply.github.com>
8614ce5 to
d8ec075
Compare
Summary
oomserver set so HIP stages 0 and 1 useenforce_eager=True.eager_oom_stage_ids(including Wan) unchanged.Confirmed failure and root cause
AMD weekly build #14733 ran the previous exact PR head
8614ce54fe4f04aa062b552a77802c567eb6477ewith a clean checkout.2 failed, 25 passed, 10 skipped; no retries.test_reliability_fault_gpu_oom_recovers_after_fault_removedvariants returned HTTP 200 while pressure was active.Why this is not a duplicate
No open PR changes
GpuOomRecovery.server_setor adds a HIP-only residual-memory ceiling to Qwen recovery. This PR does not change the HunyuanImage process-kill matrix.Contributor intent
oomserver set and apply the proven 32 MiB HIP free-memory ceiling to recovery injection. Regression tests check both Qwen scenarios, the ceiling plumbing, unchanged CUDA deployment behavior, and unchanged Wan behavior.Design and documentation
This changes only the reliability-test harness. It does not change public runtime behavior, user configuration, or an active design contract, so no user or design documentation update is required.
AI assistance disclosure
Cursor using Grok 4.7 drafted the original server-set change and regression test. Codex analyzed the MI300 failure, implemented the HIP-only residual-memory ceiling, updated regression coverage, rebased the branch, and updated this description. The changes were reviewed and the reported commands/results were verified before submission.
Test plan and current results
Changed-file pre-commit hooks passed, including Ruff, Ruff format, mypy 3.10, test marks, SPDX, forbidden imports, and
torch.cudachecks.Static regression subset runnable without Torch:
5 passed, 1 deselected.Python syntax compilation passed for both changed test files.
MI300 weekly qualification run 1: AMD #14742, Qwen job
01a17a37-58ae-4281-9730-b08fff3cb4e9,27 passed, 10 skipped, 14 warningsin1:10:05.MI300 weekly qualification run 2: AMD #14747, Qwen job
01a17a8e-e037-42c8-ac10-92268f4360a1,27 passed, 10 skipped, 14 warningsin1:08:54.Both Qwen jobs ran the exact final head with clean weekly checkouts, exited 0, had no retries or soft failures, and passed all eight OOM cases while pressure reached the 32 MiB HIP ceiling on both GPUs.
The known unrelated nonblocking HunyuanImage result was excluded from the named Qwen qualification gate.
READY AMD #14749: 33/33 records terminal and passing.
READY CUDA #18204: 18/18 records terminal and passing.
Intel #10921: 2/2 records terminal and passing.
NPU #9947: 21/21 executed records terminal and passing.
All four platform builds ran the exact final head with no nonzero exits, retries, soft failures, or unfinished records.
Current base:
c84638f3208f0fffd872200adfc5860103a6244bCurrent head:
d8ec07595844ab8aee6080bcdf49c1bc2ce7898c