Repository navigation
[cherry-pick][release/v0.32.0] Backport 14 milestone fixes and regressions (batch 4) - #9334
Merged
tzhouam merged 17 commits intoOct 24, 2026
Conversation
…ct#9248 (vllm-project#9302) Signed-off-by: Iryna Boiko <iboiko@habana.ai> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> (cherry picked from commit 8e2a7c1) Signed-off-by: tzhouam <tzhouam@connect.ust.hk>
…spans (vllm-project#9244) Signed-off-by: YawningPants <54137998+YawningPants@users.noreply.github.com> Co-authored-by: changetheway <guotaoyuan1@h-partners.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: dengyunyang <584797741@qq.com> (cherry picked from commit 0be1493) Signed-off-by: tzhouam <tzhouam@connect.ust.hk>
…get (vllm-project#9107) Signed-off-by: kunkunblueberry <1833921874@qq.com> (cherry picked from commit e1b99a8) Signed-off-by: tzhouam <tzhouam@connect.ust.hk>
…ned (vllm-project#7880) Signed-off-by: Armaan Amatya <armaanamatya2014@gmail.com> (cherry picked from commit 859103e) Signed-off-by: tzhouam <tzhouam@connect.ust.hk>
…m-project#9303) Signed-off-by: haic0 <149741444+haic0@users.noreply.github.com> Signed-off-by: andyluo7 <andy.luo@amd.com> Co-authored-by: andyluo7 <andy.luo@amd.com> (cherry picked from commit 7861026) Signed-off-by: tzhouam <tzhouam@connect.ust.hk>
…lm-project#9041) Signed-off-by: cipheraxat <cipheraxat@users.noreply.github.com> Co-authored-by: cipheraxat <cipheraxat@users.noreply.github.com> (cherry picked from commit c704a28) Signed-off-by: tzhouam <tzhouam@connect.ust.hk>
…o preprocessing (vllm-project#5784) Signed-off-by: akshatvishu <akshatnayak197@gmail.com> (cherry picked from commit c464923) Signed-off-by: tzhouam <tzhouam@connect.ust.hk>
…ing guard (vllm-project#9276) Signed-off-by: akshatvishu <akshatnayak197@gmail.com> Signed-off-by: andyluo7 <andy.luo@amd.com> Co-authored-by: akshatvishu <akshatnayak197@gmail.com> (cherry picked from commit 1edbb9e) Signed-off-by: tzhouam <tzhouam@connect.ust.hk>
…llm-project#8874) Signed-off-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com> (cherry picked from commit e900011) Signed-off-by: tzhouam <tzhouam@connect.ust.hk>
…eaves no seam (vllm-project#8868) Signed-off-by: ZhIMQ <15000371166@163.com> (cherry picked from commit 0f79bd8) Signed-off-by: tzhouam <tzhouam@connect.ust.hk>
…lar_model_index.json (vllm-project#8801) Signed-off-by: Sylvan Liu <Sylvan.Liu@amd.com> (cherry picked from commit a147aaf) Signed-off-by: tzhouam <tzhouam@connect.ust.hk>
…r decode state (vllm-project#9249) Signed-off-by: amy-why-3459 <wuhaiyan17@huawei.com> (cherry picked from commit c42398c) Signed-off-by: tzhouam <tzhouam@connect.ust.hk>
tzhouam
marked this pull request as ready for review
October 24, 2026 16:08
tzhouam
requested review from
Isotr0py,
NickCao,
RuixiangMa,
SamitHuang,
ZJY0516,
david6666666,
princepride,
wtomin,
xuechendi and
yenuo26
as code owners
October 24, 2026 16:08
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Signed-off-by: tzhouam <tzhouam@connect.ust.hk>
tzhouam
requested review from
Gaohan123,
Sy0307,
alex-jw-brooks,
amy-why-3459,
gcanlin,
hsliuustc0106,
linyueqian,
lishunyang12 and
ywang96
as code owners
October 24, 2026 16:12
Omni ReviewBot triage noteAutomated triage of commit
These are automated triage suggestions only — the final decision belongs to the maintainers. |
Signed-off-by: tzhouam <tzhouam@connect.ust.hk> (cherry picked from commit 472cbeb)
Use the existing block initialization helper before the fused and native QK norm/RoPE checks. The vLLM-backed projections otherwise read uninitialized checkpoint weight allocations. Drop the redundant bare CUDA mark already supplied by hardware_marks, preserving platform and resource selection. Signed-off-by: tzhouam <tzhouam@connect.ust.hk> (cherry picked from commit a81d739)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fourth backport batch for
release/v0.32.0, following #9295. Includes the 14 selected upstream PRs tied to v0.32.0 issues or required regression coverage. Base:bb3c0521628cfa13cdb2ace76c525c811c313b33.full_attn_spanssub-path; does not establish full issue resolution#9270 and #9273 remain separate release backports (#9274 and #9275); they are not duplicated here.
Backport adaptations
No new models or performance optimizations from the intervening main commits are included.
Contributor intent
Outcome: bring the selected v0.32.0 issue fixes and their necessary regressions to the release line. The controlling variable is whether the existing affected release paths contain these fixes. This batch backports the established upstream implementations and tests for users encountering those release failures; it does not broaden the release feature set.
Validation
Head:
bbf9bde14189e83469853f396f03e8c060f5e55b.Local CPU environment: Python 3.12.13, vLLM 0.32.0, PyTorch 2.13.0+cu130, Diffusers 0.40.0, pytest 9.1.1.
Final integrated command (from the backport checkout):
PYTHONPATH=. python -m pytest -o addopts='' -m cpu -q --tb=short \ tests/core/sched/test_omni_recompute_preemption.py \ tests/model_executor/models/test_recompute_preemption_declarations.py \ tests/model_executor/models/fish_omni/test_fish_omni_model_state.py \ tests/model_executor/models/qwen3_omni/test_qwen3_omni_preempt_replay.py \ tests/config/test_omni_config.py \ tests/diffusion/models/minimax_h3/test_fasth3_checkpoint.py \ tests/diffusion/attention/test_flash_attn.py \ tests/entrypoints/openai_api/test_tts_adapter.pyRuff, formatting, documentation lint, SPDX, forbidden imports, test marks, and applicable remaining pre-commit hooks pass. Mypy retains six pre-existing errors, reproduced on the release-base tree: four in attention/layer.py, one in duplex_omni_engine.py, and one in the pre-existing LoRA test. The new NPU helper's typing error was fixed.
Not run locally: CUDA/NPU/XPU/ROCm model E2E or hardware kernels. This environment lacks the native
vllm._Cextension and has stale installed Omni version metadata; passing CPU tests are not hardware evidence. Current-head project CI is requested withready.AI assistance: Codex prepared the backports, resolved release-context conflicts, reviewed patch scope, ran local checks, and drafted this description.
Release CI follow-ups
The original head passed CUDA 18001, AMD 14561, NPU 9742, GitHub Actions, and docs. Intel 10742 hit Level Zero
OUT_OF_RESOURCESduring unchanged Z-Image text-encoder warmup, before LoRA adapters were loaded. The same test passed on release backports 10739/10740 and main 10736 (already containing #8874). Concurrent builds shared physical devices without an affinity mask; resource interference is a supported hypothesis.The updated head also includes two minimal CI stabilizations:
kernels-data>=0.14.0.dev1before the Intel image's unisolated wheel build. The same missing-plugin-dependency error occurred on the earlier release baseline Intel 10738. An isolated Python 3.12 reproduction failed before this bootstrap and passed after; kernels-data has no Torch/Triton dependencies and the paired-runtime exclusions remain.hardware_marks. Local deterministic GPU regression passed both cases; [cherry-pick][release/v0.32.0] cherry-pick #9273: reject requests after repeated stage failures (circuit breaker) #9275's preceding-head CUDA run also passed the full 310-test model task with this fix.All applicable checks passed on the changed files. The approved 14 source backports are unchanged. On current head
7ad5f31e3750bbeaf7b0767c9e60d0b31245c6a5, Intel 10749 passed the full four-round suite with the runner's supportedZE_AFFINITY_MASK=4,5,6,7. This retained all selected tests, including the Z-Image LoRA switching test and both three-card Qwen2.5-Omni tests; the original resource error did not recur. All 11/11 current-head checks passed: CUDA 18007, AMD 14567, Intel 10749, NPU 9748, both wheel builds, CodeQL, pre-commit, DCO, and docs. The final NPU MiniCPM-o test reported5 passed, 12 deselected.