Repository navigation
[CI/Build] Update MiniCPM-o A3 C8 TTFT baseline - #9388
amy-why-3459 merged 2 commits into
Conversation
Signed-off-by: amy-why-3459 <wuhaiyan17@huawei.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
@yenuo26 @natureofnature PTAL |
|
This PR appears to be related to model: minicpm. Model owners: @y-null @yenuo26 @NickCao Routing: @y-null via semantic router, model owner; @yenuo26 via CI owner, CODEOWNERS; @NickCao via CODEOWNERS @amy-why-3459, please review your own changes and leave a short self-review comment describing what you checked. PRs without author self-review may not be assigned a reviewer. Please take a look when you have a chance. If you would like an automated review, mention @vllm-omni-review-bot in a comment. |
natureofnature
left a comment
There was a problem hiding this comment.
Checked the complete JSON diff, the C8/N128 sweep mapping, and the measurement in #9095. The A3 value is at index 2, 567.9077 × 1.10 rounds to 624.6985, and all other configuration values are unchanged. The current pre-commit and Python build checks pass. This review covers the baseline adjustment; the cited measurement is historical and does not establish current-head serving performance.
【Conclusion: Found no blocking issues in commit be9da57.】
【Action recommended: None.】
Gaohan123
left a comment
There was a problem hiding this comment.
What is the reason of relaxing the threshold?
|
@Gaohan123 Compared with the existing baseline, the Oct 18 A3 C8 run shows 35% lower first-audio latency, 49% lower RTF, and nearly doubled request throughput, at the cost of a 12% increase in text TTFT (about 62 ms). For this speech-output workload, that is a reasonable tradeoff and provides a rationale for updating the text-TTFT baseline. These results reflect the combined pipeline changes from #7929, #8908, and #9026. This PR updates the baseline to reflect the resulting audio-serving performance. Audio TTFP, RTF, and throughput should be the primary performance criteria for this workload. Text-response latency can be monitored separately with a streaming text-output workload such as Daily-Omni, using its own TTFT baseline and accuracy checks. |
Purpose
Update the MiniCPM-o 4.5 A3 mean TTFT baseline for concurrency 8 / 128 requests, as requested for #9095.
The new baseline is
567.9077 × 1.10, rounded to four decimal places. The measurement comes from issue #9095, dated 2026-10-18, using vLLM 0.31.0 and Omni72a665bbe8b4fb035baf56516d643b7fd1f6b039. Add that provenance to the configuration description.Only this baseline and its description change. This is a baseline adjustment, not a performance optimization or a new benchmark result. Runtime behavior, other metrics/concurrencies, and the comparison policy are unchanged, so serving design contracts and user guides do not change.
Contributor intent
Fix #9095
mean_ttft_msbaseline for concurrency 8 / 128 requests.Validation
git diff --check: passed.pre-commit run --files tests/dfx/perf/tests/test_minicpmo_4_5.json: all applicable checks passed.No new NPU benchmark or full test suite was run; the historical issue measurement is the evidence for the requested baseline update.
Need help on this PR? Tag
@codesmith-botwith what you need.