Skip to content

[cherry-pick][release/v0.32.0] cherry-pick #9219 - #9394

Merged
yenuo26 merged 2 commits into
vllm-project:release/v0.32.0from
ShengDev:cherry-pick/release-v0.32.0-9219
Oct 26, 2026
Merged

[cherry-pick][release/v0.32.0] cherry-pick #9219#9394
yenuo26 merged 2 commits into
vllm-project:release/v0.32.0from
ShengDev:cherry-pick/release-v0.32.0-9219

Conversation

@ShengDev

@ShengDev ShengDev commented Oct 26, 2026 •
edited by blacksmith-sh Bot
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Cherry-pick [Bugfix] Stabilize diffusion master_port precedence tests #9219 onto release/v0.32.0.
  • Test-only change: stabilize OmniDiffusionConfig.master_port precedence tests so a busy port's intended +37 step no longer fails the equality assertion.
  • The default-port case keeps a bounded loopback bind. Production port resolution is unchanged.

Test plan

  • pytest tests/diffusion/test_omni_diffusion_config_master_port.py -q — 6 passed on vLLM 0.32.0 (CPU), against the updated test file
  • Held port 42267 resolved to 42304 (+37) with the real probe; the old equality assertion fails
  • CI on this release branch

Made with Cursor

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

cursoragent and others added 2 commits October 26, 2026 14:20
@cursoragent @ShengDev
[Bugfix] Stabilize diffusion master_port precedence tests
ed3eb23 
The MASTER_PORT precedence test took a port from get_open_port() and
then required settle_port to accept that same port. The probe does not
reserve the port, so when another process takes it settle_port steps
ahead by 37 and the equality assertion fails. That step is the intended
fallback.

Stub is_port_available for every test that asserts which port was
selected, including the default-port path that previously re-bound the
resolved port.

Fixes vllm-project#9208

Signed-off-by: Cursor Agent <cursoragent@cursor.com>

Co-authored-by: Sheng GAO <sheng.gao.dev@gmail.com>
(cherry picked from commit c9f15bc)
Signed-off-by: sheng <sheng.gao.dev@gmail.com>
@ShengDev
[Test] Restore a live bind for the default master port
9940a9b 
The stubbed default-port check only repeated that settle_port returns
its first probe. Take the bounded loopback bind from vllm-project#9215, and require
the env-precedence probe list to be exactly the env port.

Signed-off-by: sheng <sheng.gao.dev@gmail.com>
(cherry picked from commit 90f017e)
Signed-off-by: sheng <sheng.gao.dev@gmail.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-26T06:20:58.213897Z
We couldn’t complete this review. Comment @codex review to try again.		 9940a9b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@vllm-omni-review-bot

vllm-omni-review-bot commented Oct 26, 2026

Copy link
Copy Markdown

This PR matches CODEOWNERS paths: /tests/.

Code owners: @NickCao @yenuo26

Routing: @NickCao via CODEOWNERS; @yenuo26 via CODEOWNERS

@ShengDev, please review your own changes and leave a short self-review comment describing what you checked. PRs without author self-review may not be assigned a reviewer.

Please take a look when you have a chance. If you would like an automated review, mention @vllm-omni-review-bot in a comment.

yenuo26
yenuo26 approved these changes Oct 26, 2026
View reviewed changes

@yenuo26 yenuo26 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yenuo26 yenuo26 added the ready label to trigger buildkite CI label Oct 26, 2026
@yenuo26
yenuo26 enabled auto-merge (squash) October 26, 2026 06:26
@vllm-omni-review-bot

vllm-omni-review-bot commented Oct 26, 2026

Copy link
Copy Markdown

Omni ReviewBot triage note

Automated triage of commit 9940a9b55bdc produced:

  • Priority: high. Prompt maintainer attention is suggested.

These are automated triage suggestions only — the final decision belongs to the maintainers.

@yenuo26
yenuo26 merged commit ab216c0 into vllm-project:release/v0.32.0 Oct 26, 2026
8 of 11 checks passed
@apapi apapi mentioned this pull request Oct 27, 2026
Merged
@tzhouam tzhouam mentioned this pull request Oct 27, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yenuo26 yenuo26 yenuo26 approved these changes
@NickCao NickCao Awaiting requested review from NickCao NickCao is a code owner

Assignees

No one assigned

Labels

ready label to trigger buildkite CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ShengDev @vllm-omni-review-bot @yenuo26 @cursoragent