Repository navigation
[Doc][release/v0.32.0] MiniMax-H3: separate reported observations from verified claims - #9381
Conversation
The Ref2VA dialogue section claimed the same prompts behave the same way across serving stacks; the NPU matrix covers attention/cache variants and the GPU report uses a different prompt, so no matched same-prompt cross-stack comparison exists. Describe the two reports and the verified raw-prompt forwarding fact, and recommend the official format as the first step (release twin of vllm-project#9331). Signed-off-by: GUOGUO <xwdong1998@163.com>
|
@Gaohan123 — small docs follow-up for the release line: #9332 landed the Ref2VA dialogue-prompt contract here, and review on the main-side twin (#9331) required narrowing the cross-stack claim (the NPU matrix covers attention/cache variants while the GPU report uses a different prompt, so no matched same-prompt comparison exists — wording now separates the reported observations from the verified forwarding fact). #9381 applies that wording fix to |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
This PR appears to be related to model: MinimaxH3. Model owners: @david6666666 @Gaohan123 @hsliuustc0106 Routing: @david6666666 via semantic router, model owner, CODEOWNERS; @Gaohan123 via CODEOWNERS; @hsliuustc0106 via CODEOWNERS @Dong1017, please review your own changes and leave a short self-review comment describing what you checked. PRs without author self-review may not be assigned a reviewer. Please take a look when you have a chance. If you would like an automated review, mention @vllm-omni-review-bot in a comment. |
Omni ReviewBot triage noteAutomated triage of commit
These are automated triage suggestions only — the final decision belongs to the maintainers. |
Purpose
Release twin of the #9331 review fix: the
Ref2VA dialogue promptssection (merged through #9332) claimed the same prompts behave the same way across serving stacks. The #8905 NPU matrix covers attention/cache variants on one stack and the separate GPU report uses a different bare-English prompt, so no matched same-prompt cross-stack comparison exists. The wording now describes the two reported observations separately plus the verified raw-prompt forwarding fact, and recommends the official format as the first step, without the cross-stack equivalence claim (review finding by @hsliuustc0106 on #9331).Test Plan
Test Result
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.