[Bugfix] Sync main into dev/migrate-MR-v2 with semantic-safe conflict resolution#2954
Merged
tzhouam merged 28 commits intovllm-project:dev/migrate-MR-v2from Apr 20, 2026
Merged
Conversation
…_generates_video[wan22_i2v_usp2_hsdp2] (vllm-project#2883) Signed-off-by: wangyu <410167048@qq.com>
Signed-off-by: Lancer <maruixiang6688@gmail.com>
…t#2343) Signed-off-by: Nick Cao <ncao@redhat.com> Co-authored-by: Claude <noreply@anthropic.com>
…ures (vllm-project#1837) Signed-off-by: CHEN <116010019@link.cuhk.edu.cn> Signed-off-by: Yueqian Lin <70319226+linyueqian@users.noreply.github.com> Signed-off-by: linyueqian <linyueqian@outlook.com> Co-authored-by: Yueqian Lin <70319226+linyueqian@users.noreply.github.com> Co-authored-by: linyueqian <linyueqian@outlook.com>
Signed-off-by: Joshna Medisetty <joshna.medisetty@intel.com> Signed-off-by: Joshna-Medisetty <joshna.medisetty@intel.com> Co-authored-by: Hongsheng Liu <liuhongsheng4@huawei.com>
Signed-off-by: Alex Brooks <albrooks@redhat.com>
Signed-off-by: hsliuustc0106 <liuhongsheng4@huawei.com> Signed-off-by: hsliu <liuhongsheng4@huawei.com> Signed-off-by: Hongsheng Liu <liuhongsheng4@huawei.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: david6666666 <david6666666@users.noreply.github.com> Co-authored-by: david6666666 <david6666666@users.noreply.github.com>
Signed-off-by: Nick Cao <ncao@redhat.com>
…t#2581) Signed-off-by: CHEN <116010019@link.cuhk.edu.cn>
Signed-off-by: princepride <wangzhipeng628@gmail.com> Signed-off-by: 汪志鹏 <wangzhipeng628@gmail.com> Co-authored-by: Hongsheng Liu <liuhongsheng4@huawei.com>
Signed-off-by: CHEN <116010019@link.cuhk.edu.cn>
Signed-off-by: Lancer <maruixiang6688@gmail.com> Co-authored-by: Samit <285365963@qq.com>
Signed-off-by: gcanlin <canlinguosdu@gmail.com>
…pt (vllm-project#2894) Signed-off-by: Sy03 <1370724210@qq.com>
…2383) Signed-off-by: lishunyang <lishunyang12@163.com> Signed-off-by: reidliu41 <reid201711@gmail.com> Signed-off-by: Alex Brooks <albrooks@redhat.com> Co-authored-by: reidliu41 <reid201711@gmail.com> Co-authored-by: xiaohajiayou <75477391+xiaohajiayou@users.noreply.github.com> Co-authored-by: Alex Brooks <albrooks@redhat.com> Co-authored-by: Hongsheng Liu <liuhongsheng4@huawei.com>
…+decode batches (vllm-project#2903) Signed-off-by: Sy03 <1370724210@qq.com>
…memory (vllm-project#2474) Signed-off-by: willamhou <willamhou@ceresman.com> Co-authored-by: willamhou <willamhou@ceresman.com>
Signed-off-by: xiaohajiayou <923390377@qq.com> Signed-off-by: Samit <285365963@qq.com> Co-authored-by: Samit <285365963@qq.com> Co-authored-by: SYLAR <125541396+lishunyang12@users.noreply.github.com>
…m-project#2018) Signed-off-by: Yuanheng Zhao <jonathan.zhaoyh@gmail.com> Signed-off-by: yuanheng <jonathan.zhaoyh@gmail.com> Co-authored-by: Didan Deng <33117903+wtomin@users.noreply.github.com>
Signed-off-by: lishunyang <lishunyang12@163.com>
…2852) Signed-off-by: fan2956 <zhoufan53@huawei.com>
Signed-off-by: Rein Yang <ruiruyang2@gmail.com>
…m-project#2934) Signed-off-by: amy-why-3459 <wuhaiyan17@huawei.com>
…dules (vllm-project#2620) Signed-off-by: wangyu <410167048@qq.com>
…resolution Signed-off-by: Sy03 <1370724210@qq.com>
Signed-off-by: Sy03 <1370724210@qq.com>
Signed-off-by: Sy03 <1370724210@qq.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
dev/migrate-MR-v2had drifted significantly behindmain, and a direct merge now carries conflicts across three layers at once:main([CI] Restructure vLLM-Omni Test Layout, Fixture Scope, and Support Modules #2620)main([Config Refactor][2/N] Pipeline + Deploy Config Schema #2383, [Config Refactor 2.5/N] Centralize pipeline registry #2915)dev/migrate-MR-v2This PR performs the sync with a conservative rule: preserve
main's structure and schema wherever possible, and only carry over the minimumdevsemantics required for MR-V2 / Qwen3-TTS / Qwen3-Omni behavior.Changes
1. Merge
origin/mainintodev/migrate-MR-v2Resolved the merge with the following policy:
mainmain's new deploy schema, keep only requireddevruntime semanticsdev's MR-V2-critical behavior without regressingmain's structure2. Keep
maintest infrastructure, adaptdev-only MR-V2 test pathsmain's thintests/conftest.pytests/utils.pyand moved usage totests/helpers/*tests/examples/offline_inference/test_qwen3_tts_mr_v2.pyimports:tests.examples.conftest→tests.examples.helperstests.utils→tests.helpers.mark3. Merge deploy yaml semantically, not textually
For:
vllm_omni/deploy/qwen3_tts.yamlvllm_omni/deploy/qwen3_omni_moe.yamlwe kept
main's deploy/schema layout and only preserved thedevsettings that actually affect runtime behavior.After checking
_build_extras()merge order invllm_omni/config/stage_config.py, we removed the deploy-side sampling params that were actually no-ops because pipeline constraints overwrite them:detokenizestop_token_ids: [2150]stop_token_ids: [0]4. Fix scheduler cleanup path on the merged branch
Adjusted
vllm_omni/core/sched/omni_generation_scheduler.pyso the already-finished path no longer routes an already-finished request throughfinish_requests()(which becomes a no-op upstream).Current behavior:
request_id not in self.requests:RequestStatus.FINISHED_STOPPEDwithout chunk adapter:already_finished_reqspath_free_request()only when scheduler-side state still existsThis avoids both:
No free indices5. Clean minor correctness / merge fallout
omni_ar_scheduler.pydeserialize_additional_informationreference to_resolve_additional_informationRisks & Considerations
This is still a large integration PR because it syncs
maininto a long-lived migration branch.Main risks:
tests/helpers/*)deploy/*.yamlsystemThe mitigations in this PR are:
main's structure wherever possibledevcarry-over to the smallest required behavior deltaTest Plan
Static / local
fix/dev-sync-main-semantic-saferuff checkpassed for touched scheduler / MR-V2 example filesRemote service validation (
/chrome-remote-gpu)/v1/audio/speech— 5 concurrent requests, all succeeded--no-async-chunkpath — 5 concurrent requests, all succeededexamples/offline_inference/qwen3_tts/end2end.py --query-type Base --mode-tag iclreturned RC=0Known limitation
torch/vllm/tests.helpers.fixtures.runtimeincompatibility (mm_configsimport failure in torch inductor plugin loading)Notes
This PR intentionally treats the merge as a semantic integration rather than a mechanical text merge. The goal is to keep
main's latest structure intact while preserving the MR-V2 runtime semantics that the migration branch still needs.cc @tzhouam @Fattysand