[BugFix] Fixed the issue where --no-async-chunk was not working.#2934
Merged
lishunyang12 merged 1 commit intovllm-project:mainfrom Apr 20, 2026
Merged
[BugFix] Fixed the issue where --no-async-chunk was not working.#2934lishunyang12 merged 1 commit intovllm-project:mainfrom
lishunyang12 merged 1 commit intovllm-project:mainfrom
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Signed-off-by: amy-why-3459 <wuhaiyan17@huawei.com>
c446a90 to
54af13c
Compare
Contributor
Author
|
@ZeldaHuang @lishunyang12 PTAL |
lishunyang12
approved these changes
Apr 20, 2026
Collaborator
lishunyang12
left a comment
There was a problem hiding this comment.
Thanks for your quick fix.
| # Provisional value (mirrors the CLI/caller kwarg); the engine resolves | ||
| # pipeline + deploy YAML + CLI precedence below and the final value is | ||
| # re-assigned from ``self.engine.async_chunk`` after init. | ||
| self.async_chunk = bool(async_chunk) if async_chunk is not None else False |
Collaborator
There was a problem hiding this comment.
I should have updated this logic in #2383 with introduction of a new flag --no-async-chunk
qinganrice
pushed a commit
to qinganrice/vllm-omni
that referenced
this pull request
Apr 23, 2026
…m-project#2934) Signed-off-by: amy-why-3459 <wuhaiyan17@huawei.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
fix #2933
Test Plan
vllm serve /home/models/Qwen3-Omni-30B-A3B-Instruct --omni --port 28889 --no-async-chunkTest Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model. Please runmkdocs serveto sync the documentation editions to./docs.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)