Skip to content

[Bugfix] fix CI failure#2884

Merged
hsliuustc0106 merged 2 commits intovllm-project:mainfrom
RuixiangMa:fixut
Apr 17, 2026
Merged

[Bugfix] fix CI failure#2884
hsliuustc0106 merged 2 commits intovllm-project:mainfrom
RuixiangMa:fixut

Conversation

@RuixiangMa
Copy link
Copy Markdown
Contributor

Purpose

[2026-04-17T12:30:45Z] ERROR tests/entrypoints/openai_api/test_image_server.py::test_image_edit_with_seed_zero - AttributeError: property 'stage_configs' of 'async_omni_test_client.<locals>.FakeAsyncOmniClass' object has no setter
--
[2026-04-17T12:30:45Z] = 2 failed, 1556 passed, 1 skipped, 698 deselected, 51 warnings, 19 errors in 338.82s (0:05:38) =

Test Plan

Test Result

pytest tests/entrypoints/openai_api/test_image_server.py -v

===================================================================================== 49 passed, 19 warnings in 3.30s ======================================================================================


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan. Please provide the test scripts & test commands. Please state the reasons if your codes don't require additional test scripts. For test file guidelines, please check the test style doc
  • The test results. Please paste the results comparison before and after, or the e2e results.
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model. Please run mkdocs serve to sync the documentation editions to ./docs.
  • (Optional) Release notes update. If your change is user-facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

Signed-off-by: Lancer <maruixiang6688@gmail.com>
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@hsliuustc0106 hsliuustc0106 added the ready label to trigger buildkite CI label Apr 17, 2026
@hsliuustc0106
Copy link
Copy Markdown
Collaborator

thanks a lot

@RuixiangMa
Copy link
Copy Markdown
Contributor Author

RuixiangMa commented Apr 17, 2026

@hsliuustc0106

FAILED tests/comfyui/test_comfyui_integration.py::test_image_generation_node[no-sampling-params-image-to-image-dalle-endpoint]
--
FAILED tests/comfyui/test_comfyui_integration.py::test_image_generation_node[single-diffusion-sampling-params-image-to-image-dalle-endpoint]

The ComfyUI endpoint tests are still failing

@hsliuustc0106
Copy link
Copy Markdown
Collaborator

@david6666666 will fix the comfyui error, @RuixiangMa can you help rm/comment these 2 tests now?

@hsliuustc0106
Copy link
Copy Markdown
Collaborator

@david6666666 will fix the comfyui error, @RuixiangMa can you help rm/comment these 2 tests now?

and open a new issue for these 2 failures

Signed-off-by: Lancer <maruixiang6688@gmail.com>
@RuixiangMa
Copy link
Copy Markdown
Contributor Author

@david6666666 will fix the comfyui error, @RuixiangMa can you help rm/comment these 2 tests now?

updated, temporarily skipped the two ComfyUI

@hsliuustc0106 hsliuustc0106 merged commit 64d368d into vllm-project:main Apr 17, 2026
6 of 8 checks passed
@RuixiangMa
Copy link
Copy Markdown
Contributor Author

@hsliuustc0106 CI failure is unrelated to the code.

lvliang-intel pushed a commit to lvliang-intel/vllm-omni that referenced this pull request Apr 20, 2026
Signed-off-by: Lancer <maruixiang6688@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants