[Agent] Add NPU main2main skill#2858
Conversation
Signed-off-by: gcanlin <canlinguosdu@gmail.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
@hsliuustc0106 PTAL |
|
BLOCKER scan:
OVERALL: 2 BLOCKERS FOUND VERDICT: REQUEST_CHANGES Blocker 1: SKILL.md exceeds 300-line limit The SKILL.md file is 300 lines, which exceeds the 300-line limit for skill bodies (the validation script enforces
Blocker 2: Incomplete PR description The Test Plan section just has a path ( Please provide:
The skill content itself is comprehensive and well-structured - good documentation of the NPU upgrade workflow, omni-specific blocks, and translation patterns. Just need to address the length limit and test documentation. |
|
any test results for this skill? |
Let me create a PR to try it. |
Signed-off-by: gcanlin <canlinguosdu@gmail.com>
Signed-off-by: gcanlin <canlinguosdu@gmail.com>
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
This skill guides the process of upgrading vllm-omni's NPU model runners to align with the latest vllm-ascend codebase while preserving omni-specific enhancements. The NPU runners are designed to run omni multimodal models (like Qwen3-Omni, Bagel, MiMoAudio) on Ascend NPUs.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model. Please runmkdocs serveto sync the documentation editions to./docs.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)