Skip to content

[skip ci][recipe] draft vllm-omni recipes#2646

Merged
hsliuustc0106 merged 3 commits intomainfrom
community-recipes
Apr 18, 2026
Merged

[skip ci][recipe] draft vllm-omni recipes#2646
hsliuustc0106 merged 3 commits intomainfrom
community-recipes

Conversation

@hsliuustc0106
Copy link
Copy Markdown
Collaborator

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

Purpose

resolve #2645

Test Plan

N.A.

Test Result

N.A.


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan. Please provide the test scripts & test commands. Please state the reasons if your codes don't require additional test scripts. For test file guidelines, please check the test style doc
  • The test results. Please paste the results comparison before and after, or the e2e results.
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model. Please run mkdocs serve to sync the documentation editions to ./docs.
  • (Optional) Release notes update. If your change is user-facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Introduces a new top-level recipes/ area intended to host community-maintained “known-good setup” runbooks (organized by model vendor) to help users run model X on hardware Y for task Z, aligned in spirit with vllm-project/recipes.

Changes:

  • Added recipes/README.md describing the intended structure and linking to the template.
  • Added recipes/TEMPLATE.md providing a standardized recipe format for contributors.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
recipes/README.md Documents the purpose and proposed vendor-based layout for community recipes.
recipes/TEMPLATE.md Adds a Markdown template to standardize recipe content (env/command/verification/notes).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread recipes/TEMPLATE.md
Comment on lines +30 to +33
### 1x A100 80GB

### Environment

Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this template, the sub-sections (Environment/Command/Verification/Notes) are at the same heading level as the hardware configuration ("### 1x A100 80GB"), which flattens the structure and makes it harder to render/navigate. Consider nesting these under the hardware config (e.g., make them one level deeper) so each hardware section is self-contained.

Copilot uses AI. Check for mistakes.
Comment thread recipes/README.md Outdated
Comment thread recipes/README.md Outdated
Comment thread recipes/README.md
Comment on lines +12 to +21
Example layout:

```text
recipes/
Qwen/
Qwen3-Omni.md
Qwen3-TTS.md
Tencent-Hunyuan/
HunyuanVideo.md
```
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description indicates it "resolve #2645", but the RFC’s scope/success criteria include adding vendor-organized recipe docs (e.g., recipes/Qwen/Qwen3-Omni.md, etc.). This PR currently adds only a template and README; either add at least one initial recipe under a vendor directory, or adjust the PR description/issue-closing keyword so it doesn’t prematurely close the issue.

Copilot uses AI. Check for mistakes.
hsliuustc0106 and others added 3 commits April 18, 2026 09:47
Signed-off-by: hsliuustc0106 <liuhongsheng4@huawei.com>
Signed-off-by: hsliu <liuhongsheng4@huawei.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Hongsheng Liu <liuhongsheng4@huawei.com>
Signed-off-by: hsliu <liuhongsheng4@huawei.com>
Signed-off-by: hsliu <liuhongsheng4@huawei.com>
@hsliuustc0106 hsliuustc0106 changed the title [WIP][recipe] draft vllm-omni recipes [skip ci][recipe] draft vllm-omni recipes Apr 18, 2026
@hsliuustc0106 hsliuustc0106 merged commit 5a68c21 into main Apr 18, 2026
4 checks passed
lvliang-intel pushed a commit to lvliang-intel/vllm-omni that referenced this pull request Apr 20, 2026
Signed-off-by: hsliuustc0106 <liuhongsheng4@huawei.com>
Signed-off-by: hsliu <liuhongsheng4@huawei.com>
Signed-off-by: Hongsheng Liu <liuhongsheng4@huawei.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
qinganrice pushed a commit to qinganrice/vllm-omni that referenced this pull request Apr 23, 2026
Signed-off-by: hsliuustc0106 <liuhongsheng4@huawei.com>
Signed-off-by: hsliu <liuhongsheng4@huawei.com>
Signed-off-by: Hongsheng Liu <liuhongsheng4@huawei.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue]: Add vendor-organized community recipes for “run model X on hardware Y for task Z” in vLLM-Omni

2 participants