Skip to content

fix topo use in local_example#18357

Merged
rohit-nayak-ps merged 5 commits intovitessio:mainfrom
morgo:fix-topo-import-to-tests
Jul 21, 2025
Merged

fix topo use in local_example#18357
rohit-nayak-ps merged 5 commits intovitessio:mainfrom
morgo:fix-topo-import-to-tests

Conversation

@morgo
Copy link
Contributor

@morgo morgo commented Jun 13, 2025

Description

The TOPO environment variable was not being passed into the docker environment for tests.

This meant that only etcd was ever being tested:

Related Issue(s)

Fixes #18355

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Morgan Tocker <tocker@gmail.com>
@morgo morgo requested a review from deepthi as a code owner June 13, 2025 17:56
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Jun 13, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jun 13, 2025
@github-actions github-actions bot added this to the v23.0.0 milestone Jun 13, 2025
Signed-off-by: Morgan Tocker <tocker@gmail.com>
@morgo morgo requested a review from rohit-nayak-ps as a code owner June 13, 2025 18:03
@morgo morgo marked this pull request as draft June 13, 2025 19:54
@morgo
Copy link
Contributor Author

morgo commented Jun 13, 2025

Converting back to a draft, zk is broken too.

Edit: ZK was fixed by #18407 merging.

@morgo morgo force-pushed the fix-topo-import-to-tests branch from bf41bda to 0865f07 Compare June 13, 2025 21:27
@morgo morgo marked this pull request as ready for review June 13, 2025 21:43
@morgo morgo force-pushed the fix-topo-import-to-tests branch 2 times, most recently from 9ebd749 to f7bdabe Compare June 16, 2025 13:34
@morgo morgo marked this pull request as draft June 16, 2025 14:29
@morgo morgo marked this pull request as draft June 16, 2025 14:29
@morgo morgo marked this pull request as draft June 16, 2025 14:29
@morgo morgo marked this pull request as draft June 16, 2025 14:29
@morgo morgo force-pushed the fix-topo-import-to-tests branch 2 times, most recently from cfe2ee3 to 8d29285 Compare June 16, 2025 15:46
Signed-off-by: Morgan Tocker <tocker@gmail.com>
@morgo morgo force-pushed the fix-topo-import-to-tests branch from 8d29285 to 54b06e1 Compare June 16, 2025 16:17
@morgo morgo marked this pull request as ready for review June 16, 2025 17:17
@morgo
Copy link
Contributor Author

morgo commented Jun 16, 2025

The deadlock issue causing the unit test / unit_race test to fail is #18276 - I left a comment on the issue.

The code coverage test is failing due to a timeout in grpctmserver. It looks like a flaky test/unrelated.

@morgo morgo requested a review from mattlord June 17, 2025 18:46
Signed-off-by: Morgan Tocker <tocker@gmail.com>
@codecov
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 67.48%. Comparing base (b111270) to head (11626f7).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/topo/zk2topo/lock.go 70.58% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18357      +/-   ##
==========================================
- Coverage   67.49%   67.48%   -0.01%     
==========================================
  Files        1603     1603              
  Lines      262426   262490      +64     
==========================================
+ Hits       177112   177138      +26     
- Misses      85314    85352      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…tests

* origin/master: (32 commits)
  test: Fix race condition in TestStreamRowsHeartbeat (vitessio#18414)
  VReplication: Improve permission check logic on external tablets on SwitchTraffic (vitessio#18348)
  Perform post copy actions in atomic copy (vitessio#18411)
  Update `operator.yaml` (vitessio#18364)
  Feature(onlineddl): Add shard-specific completion to online ddl (vitessio#18331)
  Set parsed comments in operator for subqueries (vitessio#18369)
  `vtorc`: move shard primary timestamp to time type (vitessio#18401)
  `vtorc`: rename `isClusterWideRecovery` -> `isShardWideRecovery` (vitessio#18351)
  `vtorc`: remove dupe keyspace/shard in replication analysis (vitessio#18395)
  Topo: Add NamedLock test for zk2 and consul and get them passing (vitessio#18407)
  Handle MySQL 9.x as New Flavor in getFlavor() (vitessio#18399)
  Add support for sending grpc server backend metrics via ORCA (vitessio#18282)
  asthelpergen: add design documentation (vitessio#18403)
  `vtorc`: add keyspace/shard labels to recoveries stats (vitessio#18304)
  `vtorc`: cleanup `database_instance` location fields (vitessio#18339)
  avoid derived tables for UNION when possible (vitessio#18393)
  [Bugfix] Broken Heartbeat system in Row Streamer (vitessio#18390)
  Update MAINTAINERS.md (vitessio#18394)
  move vmg to emeritus (vitessio#18388)
  Make sure to check if the server is closed in etcd2topo (vitessio#18352)
  ...
Copy link
Member

@derekperkins derekperkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on the consensus from the community call. I don't have permissions to update tests as required or not

@rohit-nayak-ps rohit-nayak-ps added Type: Bug Component: Examples and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jul 21, 2025
@rohit-nayak-ps rohit-nayak-ps merged commit 29836cd into vitessio:main Jul 21, 2025
105 of 111 checks passed
morgo added a commit to morgo/vitess that referenced this pull request Jul 21, 2025
* origin/master:
  bugfix: Fix impossible query for UNION (vitessio#18463)
  fix topo use in local_example (vitessio#18357)
  fix: update go-upgrade tool to check patch number (vitessio#18252) (vitessio#18402)
  Update MAINTAINERS.md and CODEOWNERS (vitessio#18462)
  Add logging to binlog watcher actions (vitessio#18264)
  `schemadiff`: `RelatedForeignKeyTables()` (vitessio#18195)
  `vtorc`: allow recoveries to be disabled from startup (vitessio#18005)
  Fix `vttablet` not being marked as not serving when MySQL stalls (vitessio#17883)
  make xtrabackup ShouldDrainForBackup configurable (vitessio#18431)
  Reset in-memory sequence info on vttablet on UpdateSequenceTables request (vitessio#18415)
  Fix watcher storm during topo outages (vitessio#18434)
  Online DDL: resume vreplication after cut-over/RENAME failure (vitessio#18428)
  Online DDL cutover enhancements (vitessio#18423)
  VStreamer: change in filter logic (vitessio#18319)
  Online DDL metrics: `OnlineDDLStaleMigrationMinutes` (vitessio#18417)

Signed-off-by: Morgan Tocker <tocker@gmail.com>
morgo added a commit to morgo/vitess that referenced this pull request Jul 29, 2025
…rds-new2

* origin/master:
  bugfix: Fix impossible query for UNION (vitessio#18463)
  fix topo use in local_example (vitessio#18357)
  fix: update go-upgrade tool to check patch number (vitessio#18252) (vitessio#18402)
  Update MAINTAINERS.md and CODEOWNERS (vitessio#18462)
  Add logging to binlog watcher actions (vitessio#18264)
  `schemadiff`: `RelatedForeignKeyTables()` (vitessio#18195)
  `vtorc`: allow recoveries to be disabled from startup (vitessio#18005)
  Fix `vttablet` not being marked as not serving when MySQL stalls (vitessio#17883)
  make xtrabackup ShouldDrainForBackup configurable (vitessio#18431)

Signed-off-by: Morgan Tocker <tocker@gmail.com>
mhamza15 pushed a commit that referenced this pull request Jan 30, 2026
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug Report: local_example is only testing etcd topo in matrix build

4 participants