Add logging to binlog watcher actions#18264
Merged
harshit-gangal merged 2 commits intovitessio:mainfrom Jul 16, 2025
Merged
Conversation
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18264 +/- ##
=======================================
Coverage 67.49% 67.49%
=======================================
Files 1603 1603
Lines 262428 262429 +1
=======================================
+ Hits 177114 177137 +23
+ Misses 85314 85292 -22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
harshit-gangal
approved these changes
Jun 4, 2025
harshit-gangal
requested changes
Jun 4, 2025
Member
harshit-gangal
left a comment
There was a problem hiding this comment.
you need to sign the commit. DCO is complaining.
96347f0 to
1d959d9
Compare
added 2 commits
June 9, 2025 11:44
Signed-off-by: Ben Lockhart <blockhart@hubspot.com>
Signed-off-by: Ben Lockhart <blockhart@hubspot.com>
1d959d9 to
8cfa316
Compare
harshit-gangal
approved these changes
Jun 11, 2025
ghost
approved these changes
Jun 11, 2025
Contributor
|
This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:
If no action is taken within 7 days, this PR will be closed. |
morgo
added a commit
to morgo/vitess
that referenced
this pull request
Jul 21, 2025
* origin/master: bugfix: Fix impossible query for UNION (vitessio#18463) fix topo use in local_example (vitessio#18357) fix: update go-upgrade tool to check patch number (vitessio#18252) (vitessio#18402) Update MAINTAINERS.md and CODEOWNERS (vitessio#18462) Add logging to binlog watcher actions (vitessio#18264) `schemadiff`: `RelatedForeignKeyTables()` (vitessio#18195) `vtorc`: allow recoveries to be disabled from startup (vitessio#18005) Fix `vttablet` not being marked as not serving when MySQL stalls (vitessio#17883) make xtrabackup ShouldDrainForBackup configurable (vitessio#18431) Reset in-memory sequence info on vttablet on UpdateSequenceTables request (vitessio#18415) Fix watcher storm during topo outages (vitessio#18434) Online DDL: resume vreplication after cut-over/RENAME failure (vitessio#18428) Online DDL cutover enhancements (vitessio#18423) VStreamer: change in filter logic (vitessio#18319) Online DDL metrics: `OnlineDDLStaleMigrationMinutes` (vitessio#18417) Signed-off-by: Morgan Tocker <tocker@gmail.com>
morgo
added a commit
to morgo/vitess
that referenced
this pull request
Jul 29, 2025
…rds-new2 * origin/master: bugfix: Fix impossible query for UNION (vitessio#18463) fix topo use in local_example (vitessio#18357) fix: update go-upgrade tool to check patch number (vitessio#18252) (vitessio#18402) Update MAINTAINERS.md and CODEOWNERS (vitessio#18462) Add logging to binlog watcher actions (vitessio#18264) `schemadiff`: `RelatedForeignKeyTables()` (vitessio#18195) `vtorc`: allow recoveries to be disabled from startup (vitessio#18005) Fix `vttablet` not being marked as not serving when MySQL stalls (vitessio#17883) make xtrabackup ShouldDrainForBackup configurable (vitessio#18431) Signed-off-by: Morgan Tocker <tocker@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding visibility to certain binlog watcher and VStream actions so that they can be more accurately triaged after an outage.
Related Issue(s)
Fixes: #18255
Checklist
Deployment Notes