VReplication: Improve permission check logic on external tablets on SwitchTraffic#18348
Merged
rohit-nayak-ps merged 6 commits intovitessio:mainfrom Jul 5, 2025
Merged
Conversation
…t cases. Return error from checked tablet to ensure correct sidecardb name is used Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
jonahberquist
approved these changes
Jun 10, 2025
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18348 +/- ##
=======================================
Coverage 67.49% 67.49%
=======================================
Files 1603 1603
Lines 262428 262448 +20
=======================================
+ Hits 177114 177139 +25
+ Misses 85314 85309 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
deepthi
reviewed
Jun 11, 2025
notfelineit
approved these changes
Jun 25, 2025
beingnoble03
approved these changes
Jul 4, 2025
| ) | ||
| ) | ||
| limit 1 | ||
|
|
Member
There was a problem hiding this comment.
nit: i think this empty line was left unintentionally?
Member
Author
There was a problem hiding this comment.
👍🏽 Let's fix it later, don't want to monitor yet another CI cycle to fix this nit!
morgo
added a commit
to morgo/vitess
that referenced
this pull request
Jul 7, 2025
…tests * origin/master: (32 commits) test: Fix race condition in TestStreamRowsHeartbeat (vitessio#18414) VReplication: Improve permission check logic on external tablets on SwitchTraffic (vitessio#18348) Perform post copy actions in atomic copy (vitessio#18411) Update `operator.yaml` (vitessio#18364) Feature(onlineddl): Add shard-specific completion to online ddl (vitessio#18331) Set parsed comments in operator for subqueries (vitessio#18369) `vtorc`: move shard primary timestamp to time type (vitessio#18401) `vtorc`: rename `isClusterWideRecovery` -> `isShardWideRecovery` (vitessio#18351) `vtorc`: remove dupe keyspace/shard in replication analysis (vitessio#18395) Topo: Add NamedLock test for zk2 and consul and get them passing (vitessio#18407) Handle MySQL 9.x as New Flavor in getFlavor() (vitessio#18399) Add support for sending grpc server backend metrics via ORCA (vitessio#18282) asthelpergen: add design documentation (vitessio#18403) `vtorc`: add keyspace/shard labels to recoveries stats (vitessio#18304) `vtorc`: cleanup `database_instance` location fields (vitessio#18339) avoid derived tables for UNION when possible (vitessio#18393) [Bugfix] Broken Heartbeat system in Row Streamer (vitessio#18390) Update MAINTAINERS.md (vitessio#18394) move vmg to emeritus (vitessio#18388) Make sure to check if the server is closed in etcd2topo (vitessio#18352) ...
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We also use this PR to increase the
--vreplication-copy-phase-max-innodb-history-list-lengthto10MBsince we have found that the current default of1MBis too conservative and is throttling workflows unnecessarily, especially for atomic copy workflows or for clusters with a high qps.Related Issue(s)
#18349
Checklist
Deployment Notes