Skip to content

vtorc: cleanup database_instance location fields#18339

Merged
deepthi merged 1 commit intovitessio:mainfrom
timvaillancourt:vtorc-cleanup-location-instance-fields
Jun 25, 2025
Merged

vtorc: cleanup database_instance location fields#18339
deepthi merged 1 commit intovitessio:mainfrom
timvaillancourt:vtorc-cleanup-location-instance-fields

Conversation

@timvaillancourt
Copy link
Contributor

@timvaillancourt timvaillancourt commented Jun 8, 2025

Description

This PR cleans up location-related database_instance fields in VTOrc, replacing 3 x fields with a new field: cell varchar(32)

It seems none of the removed fields were actually used in logic, with physical_environment and region always undef/"" and data_center == the tablet cell

The 3 x fields are replaced by the new cell field. It isn't used in any logic yet - for now it is informational

Related Issue(s)

Resolves #18344

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@timvaillancourt timvaillancourt added Type: Internal Cleanup Component: VTOrc Vitess Orchestrator integration labels Jun 8, 2025
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Jun 8, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jun 8, 2025
@github-actions github-actions bot added this to the v23.0.0 milestone Jun 8, 2025
@timvaillancourt timvaillancourt force-pushed the vtorc-cleanup-location-instance-fields branch from a274a9d to 9292cc0 Compare June 9, 2025 18:37
@timvaillancourt timvaillancourt removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jun 9, 2025
@timvaillancourt timvaillancourt marked this pull request as ready for review June 9, 2025 21:49
@codecov
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.49%. Comparing base (2520f7f) to head (67c30c6).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtorc/inst/instance_dao.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18339   +/-   ##
=======================================
  Coverage   67.49%   67.49%           
=======================================
  Files        1603     1603           
  Lines      262428   262433    +5     
=======================================
+ Hits       177114   177123    +9     
+ Misses      85314    85310    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvaillancourt timvaillancourt removed the NeedsIssue A linked issue is missing for this Pull Request label Jun 9, 2025
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt force-pushed the vtorc-cleanup-location-instance-fields branch from 8231b3b to 67c30c6 Compare June 9, 2025 22:35
Copy link
Contributor

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@deepthi deepthi merged commit fae2b51 into vitessio:main Jun 25, 2025
104 of 109 checks passed
@timvaillancourt timvaillancourt deleted the vtorc-cleanup-location-instance-fields branch June 25, 2025 20:10
morgo added a commit to morgo/vitess that referenced this pull request Jul 7, 2025
…tests

* origin/master: (32 commits)
  test: Fix race condition in TestStreamRowsHeartbeat (vitessio#18414)
  VReplication: Improve permission check logic on external tablets on SwitchTraffic (vitessio#18348)
  Perform post copy actions in atomic copy (vitessio#18411)
  Update `operator.yaml` (vitessio#18364)
  Feature(onlineddl): Add shard-specific completion to online ddl (vitessio#18331)
  Set parsed comments in operator for subqueries (vitessio#18369)
  `vtorc`: move shard primary timestamp to time type (vitessio#18401)
  `vtorc`: rename `isClusterWideRecovery` -> `isShardWideRecovery` (vitessio#18351)
  `vtorc`: remove dupe keyspace/shard in replication analysis (vitessio#18395)
  Topo: Add NamedLock test for zk2 and consul and get them passing (vitessio#18407)
  Handle MySQL 9.x as New Flavor in getFlavor() (vitessio#18399)
  Add support for sending grpc server backend metrics via ORCA (vitessio#18282)
  asthelpergen: add design documentation (vitessio#18403)
  `vtorc`: add keyspace/shard labels to recoveries stats (vitessio#18304)
  `vtorc`: cleanup `database_instance` location fields (vitessio#18339)
  avoid derived tables for UNION when possible (vitessio#18393)
  [Bugfix] Broken Heartbeat system in Row Streamer (vitessio#18390)
  Update MAINTAINERS.md (vitessio#18394)
  move vmg to emeritus (vitessio#18388)
  Make sure to check if the server is closed in etcd2topo (vitessio#18352)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: VTOrc Vitess Orchestrator integration Type: Internal Cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: consolidate location fields in VTorc backend

3 participants