fix: update go-upgrade tool to check patch number (#18252)#18402
Merged
systay merged 1 commit intovitessio:mainfrom Jul 21, 2025
Merged
fix: update go-upgrade tool to check patch number (#18252)#18402systay merged 1 commit intovitessio:mainfrom
systay merged 1 commit intovitessio:mainfrom
Conversation
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Contributor
Author
Signed-off-by: Arshdeep54 <balarsh535@gmail.com>
Collaborator
|
@Arshdeep54 Thank you for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18402 +/- ##
==========================================
+ Coverage 67.51% 67.52% +0.01%
==========================================
Files 1607 1607
Lines 262687 262687
==========================================
+ Hits 177340 177382 +42
+ Misses 85347 85305 -42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@systay , can you help me fix the failed CI? |
systay
approved these changes
Jul 21, 2025
frouioui
approved these changes
Jul 21, 2025
morgo
added a commit
to morgo/vitess
that referenced
this pull request
Jul 21, 2025
* origin/master: bugfix: Fix impossible query for UNION (vitessio#18463) fix topo use in local_example (vitessio#18357) fix: update go-upgrade tool to check patch number (vitessio#18252) (vitessio#18402) Update MAINTAINERS.md and CODEOWNERS (vitessio#18462) Add logging to binlog watcher actions (vitessio#18264) `schemadiff`: `RelatedForeignKeyTables()` (vitessio#18195) `vtorc`: allow recoveries to be disabled from startup (vitessio#18005) Fix `vttablet` not being marked as not serving when MySQL stalls (vitessio#17883) make xtrabackup ShouldDrainForBackup configurable (vitessio#18431) Reset in-memory sequence info on vttablet on UpdateSequenceTables request (vitessio#18415) Fix watcher storm during topo outages (vitessio#18434) Online DDL: resume vreplication after cut-over/RENAME failure (vitessio#18428) Online DDL cutover enhancements (vitessio#18423) VStreamer: change in filter logic (vitessio#18319) Online DDL metrics: `OnlineDDLStaleMigrationMinutes` (vitessio#18417) Signed-off-by: Morgan Tocker <tocker@gmail.com>
morgo
added a commit
to morgo/vitess
that referenced
this pull request
Jul 29, 2025
…rds-new2 * origin/master: bugfix: Fix impossible query for UNION (vitessio#18463) fix topo use in local_example (vitessio#18357) fix: update go-upgrade tool to check patch number (vitessio#18252) (vitessio#18402) Update MAINTAINERS.md and CODEOWNERS (vitessio#18462) Add logging to binlog watcher actions (vitessio#18264) `schemadiff`: `RelatedForeignKeyTables()` (vitessio#18195) `vtorc`: allow recoveries to be disabled from startup (vitessio#18005) Fix `vttablet` not being marked as not serving when MySQL stalls (vitessio#17883) make xtrabackup ShouldDrainForBackup configurable (vitessio#18431) Signed-off-by: Morgan Tocker <tocker@gmail.com>
mhamza15
added a commit
that referenced
this pull request
Jan 19, 2026
In #18402, logic was added to make sure that patch versions are considered for upgrades, but this had the unintended effect of making non-major version upgrades stop working. This fixes that and also additionally adds a stricter check for existing PRs in the workflow. Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
mhamza15
added a commit
that referenced
this pull request
Jan 19, 2026
In #18402, logic was added to make sure that patch versions are considered for upgrades, but this had the unintended effect of making non-major version upgrades stop working. This fixes that and also additionally adds a stricter check for existing PRs in the workflow. Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
5 tasks
mhamza15
added a commit
to mhamza15/vitess
that referenced
this pull request
Jan 24, 2026
In vitessio#18402, logic was added to make sure that patch versions are considered for upgrades, but this had the unintended effect of making non-major version upgrades stop working. This fixes that and also additionally adds a stricter check for existing PRs in the workflow. Signed-off-by: Mohamed Hamza <mhamza@fastmail.com> (cherry picked from commit 91d6d9d)
mhamza15
pushed a commit
to mhamza15/vitess
that referenced
this pull request
Jan 24, 2026
…itessio#18402) Signed-off-by: Arshdeep54 <balarsh535@gmail.com>
mhamza15
pushed a commit
to mhamza15/vitess
that referenced
this pull request
Jan 24, 2026
…itessio#18402) Signed-off-by: Arshdeep54 <balarsh535@gmail.com> Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This
isSameVersionfunction also checks for the patch number.Related Issue(s)
#18252
Checklist
Deployment Notes